From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id EB1FEE0123C for ; Wed, 21 Dec 2011 09:04:14 -0800 (PST) Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga102.ch.intel.com with ESMTP; 21 Dec 2011 09:02:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="88172852" Received: from unknown (HELO envy.home) ([10.255.12.115]) by azsmga001.ch.intel.com with ESMTP; 21 Dec 2011 09:02:46 -0800 Message-ID: <4EF21124.2050501@linux.intel.com> Date: Wed, 21 Dec 2011 09:02:28 -0800 From: Darren Hart User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 MIME-Version: 1.0 To: Richard Purdie References: <64ce10cdc685f9f5c0288df4bd0ab276711148d6.1324456294.git.dvhart@linux.intel.com> <1324484918.18348.7.camel@ted> <4EF20DBB.6040200@linux.intel.com> In-Reply-To: <4EF20DBB.6040200@linux.intel.com> X-Enigmail-Version: 1.3.3 Cc: Yocto Project Subject: Re: [PATCH 6/9] distro: Factor out poky-common.inc from poky.conf X-BeenThere: yocto@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Discussion of all things Yocto List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Dec 2011 17:04:15 -0000 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 12/21/2011 08:47 AM, Darren Hart wrote: > > > On 12/21/2011 08:28 AM, Richard Purdie wrote: >> On Wed, 2011-12-21 at 01:02 -0800, Darren Hart wrote: >>> Prepare to add additional poky distro variants by factoring out >>> assignments common to all poky* distros into poky-common.inc. Things >>> like the naming schemes, mirrors, etc. are common, while dependencies >>> and other things impacting image generation should be distro specific. >>> >>> Signed-off-by: Darren Hart >> >> Why doesn't something like: >> >> """ >> $meta-yocto/conf/distro$ cat poky-lsb.conf >> require conf/distro/poky.conf >> >> DISTRO = "poky-lsb" >> DISTROOVERRIDES = "poky:linuxstdbase" >> """ >> >> work? >> >> Effectively the above takes poky but then customises it... > > I seem to recall something about this being harder with tiny as it > removes things rather than just extending. But I can't put recall > exactly what the issue was (or if there was one). I shall try it this > way if you prefer this approach. I felt the .inc approach provided a > more explicit building block mechanism which seemed more intuitive and > less prone to accidental inclusion. But, I don't feel strongly one way > or the other. Aha, now I remember. Consider things like the following, defined in poky.conf: DISTRO_FEATURES_append = " largefile opengl" This one, not so bad, I can easily override it. PREFERRED_VERSION_linux-yocto ?= "2.6.37+git%" PREFERRED_VERSION_linux-yocto_qemux86 ?= "3.0%" PREFERRED_VERSION_linux-yocto_qemux86-64 ?= "3.0%" PREFERRED_VERSION_linux-yocto_qemuarm ?= "3.0%" PREFERRED_VERSION_linux-yocto_qemumips ?= "3.0%" PREFERRED_VERSION_linux-yocto_qemuppc ?= "3.0%" All the above I could override.... but I'd rather be able to use the default without having to override them. This pollutes my distro config space unnecessarily in my opinion. DISTRO_EXTRA_RRECOMMENDS += "kernel-module-af-packet" Things like this are the kicker. I don't know of a way to remove just what poky.conf appended to a variable, and not wipe out the rest of the variable. -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel