From: "Arend van Spriel" <arend@broadcom.com>
To: "Dan Carpenter" <dan.carpenter@oracle.com>
Cc: "Franky (Zhenhui) Lin" <frankyl@broadcom.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: brcm: list of smatch warnings
Date: Wed, 21 Dec 2011 18:47:13 +0100 [thread overview]
Message-ID: <4EF21BA1.3020806@broadcom.com> (raw)
In-Reply-To: <20111215112947.GB3906@elgon.mountain>
On 12/15/2011 12:29 PM, Dan Carpenter wrote:
> Smatch still complains about the brcm driver. Could you take a look at
> these messages? It's mostly just cleanups like doing the correct cast
> for min_t() or handling the default cases on switch statements etc or
> verifying that we broke out of a loop instead of coming to the end
> without finding what we were looking for.
As promised I took a look at the smatch complaints.
> drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c +1710 wlc_phy_txpower_reg_limit_calc(50) error: potential null derefence 'txpwr_ptr1'.
> drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c +1719 wlc_phy_txpower_reg_limit_calc(59) error: potential null derefence 'txpwr_ptr2'.
However, I am not sure about these two. Reading the code these seem
false positives. Could you confirm or correct me on these.
Gr. AvS
next prev parent reply other threads:[~2011-12-21 17:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 11:29 brcm: list of smatch warnings Dan Carpenter
2011-12-15 11:40 ` Arend van Spriel
2011-12-21 17:47 ` Arend van Spriel [this message]
2011-12-21 18:19 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF21BA1.3020806@broadcom.com \
--to=arend@broadcom.com \
--cc=dan.carpenter@oracle.com \
--cc=frankyl@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.