From: Pontus Fuchs <pontus.fuchs@gmail.com>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: ido@wizery.com, coelho@ti.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wl12xx: Fix power control for CONFIG_RUNTIME_PM off configurations
Date: Thu, 22 Dec 2011 08:44:27 +0100 [thread overview]
Message-ID: <4EF2DFDB.3070501@gmail.com> (raw)
In-Reply-To: <CAK=WgbacGjAzXPSWd1sF0RwyJ3tbMYTrZM0v2sO-pd5heSawVQ@mail.gmail.com>
Hi,
On 2011-12-22 07:39, Ohad Ben-Cohen wrote:
>> - /* Tell PM core that we don't need the card to be powered now */
>> - pm_runtime_put_noidle(&func->dev);
>> + /* Power off as we don't need the card to be powered now */
>> + wl12xx_sdio_power_off(func);
>
> This in particular looks wrong.
>
> You bypass runtime PM by manipulating the power state of the card
> directly, and as a result you leave the runtime PM state out of sync
> with the real power state of the device.
Even without my changes we will call wl12xx_sdio_power_on/off for every
ifconfig up/down. Is that also a problem or is that case different?
//Pontus
next prev parent reply other threads:[~2011-12-22 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 11:41 [PATCH] wl12xx: Fix power control for CONFIG_RUNTIME_PM off configurations Pontus Fuchs
2011-12-22 6:39 ` Ohad Ben-Cohen
2011-12-22 7:44 ` Pontus Fuchs [this message]
2011-12-22 7:51 ` Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF2DFDB.3070501@gmail.com \
--to=pontus.fuchs@gmail.com \
--cc=coelho@ti.com \
--cc=ido@wizery.com \
--cc=linux-wireless@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.