From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: Peter Lustig <peter.lustig.7db@gmail.com>
Subject: Re: New command to check NT's hibernation state
Date: Thu, 22 Dec 2011 13:10:25 +0100 [thread overview]
Message-ID: <4EF31E31.9020007@gmail.com> (raw)
In-Reply-To: <4EED5B22.1090904@gmail.com>
On 18.12.2011 04:16, Peter Lustig wrote:
> /* Return SUCCESS if magic indicates file is active; else return FAILURE */
> if (!grub_strncasecmp ("hibr", hibr_file_magic, magic_size))
What's the reason to use strncasecmp? Does the case changes? Usually
memcmp is the right way to check the signature. This also avoids the
need of memset and trailing zero byte.
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
next prev parent reply other threads:[~2011-12-22 12:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.171.1324141254.27913.grub-devel@gnu.org>
2011-12-18 3:16 ` New command to check NT's hibernation state Peter Lustig
2011-12-22 12:10 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2013-11-04 0:48 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-04 13:13 ` Andrey Borzenkov
2013-11-04 13:24 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-04 1:55 Peter Lustig
[not found] <mailman.235.1324573308.26580.grub-devel@gnu.org>
2011-12-23 4:32 ` Peter Lustig
2012-08-12 4:23 ` Peter Lustig
2013-01-28 18:11 ` Vladimir 'φ-coder/phcoder' Serbinenko
[not found] <mailman.213.1324054906.20674.grub-devel@gnu.org>
2011-12-17 5:41 ` Peter Lustig
2011-12-17 11:39 ` Vladimir 'φ-coder/phcoder' Serbinenko
[not found] <mailman.207.1322931671.23776.grub-devel@gnu.org>
2011-12-10 6:03 ` Peter Lustig
2011-12-16 15:25 ` Vladimir 'φ-coder/phcoder' Serbinenko
2011-12-16 15:30 ` Vladimir 'φ-coder/phcoder' Serbinenko
-- strict thread matches above, loose matches on Subject: below --
2011-12-03 4:57 Peter Lustig
2011-12-03 10:41 ` Vladimir 'φ-coder/phcoder' Serbinenko
2011-12-02 5:16 Peter Lustig
2011-12-02 6:05 ` Vladimir 'φ-coder/phcoder' Serbinenko
2011-11-27 23:49 Peter Lustig
2011-11-28 1:03 ` Vladimir 'φ-coder/phcoder' Serbinenko
2011-11-28 13:27 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF31E31.9020007@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
--cc=peter.lustig.7db@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.