All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tossati <mtosatti@redhat.com>,
	Carsten Otte <cotte@de.ibm.com>, Alexander Graf <agraf@suse.de>,
	Jens Freimann <jfrei@linux.vnet.ibm.com>,
	Cornelia Huck <cornelia.huck@de.ibm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	KVM <kvm@vger.kernel.org>
Subject: Re: [patch 3/3] kvm-s390: provide general purpose registers via kvm_run
Date: Thu, 22 Dec 2011 13:39:37 +0100	[thread overview]
Message-ID: <4EF32509.80200@de.ibm.com> (raw)
In-Reply-To: <4EF323DB.5000203@redhat.com>

On 22/12/11 13:34, Avi Kivity wrote:
>> The general purpose registers are often necessary to handle SIE exits.
>> Avoid additional ioctls by providing the guest registers in the r/w 
>> section of the kvm_run structure.
>>
> 
> This is only needed for S390_UCONTROL?

No for the standard path. It was more like a "we copy the regs around
anyway inside the kernel, so why not use kvm_run as a place to store 
the guest regs". So I will probably also have a look at floating point
regs and access registers.

> 
>>  
>>  struct sync_rw_regs {
>> +	__u64 gprs[16];	/* general purpose registers */
>>  };
>>  #endif
> 
> Don't you have to remove arch.guest_gprs too? (interesting approach btw).

Yes. Done


  reply	other threads:[~2011-12-22 12:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-22 11:56 [patch 0/3] RFC: provide synchronous registers in kvm_run Christian Borntraeger
2011-12-22 11:56 ` [patch 1/3] kvm: " Christian Borntraeger
2011-12-22 12:28   ` Avi Kivity
2012-01-09 12:59   ` Alexander Graf
2011-12-22 11:56 ` [patch 2/3] kvm-s390: provide the prefix register via kvm_run Christian Borntraeger
2011-12-22 11:56 ` [patch 3/3] kvm-s390: provide general purpose registers " Christian Borntraeger
2011-12-22 12:34   ` Avi Kivity
2011-12-22 12:39     ` Christian Borntraeger [this message]
2011-12-22 12:46       ` Avi Kivity
2011-12-22 12:41   ` Heiko Carstens
2011-12-22 12:47     ` Avi Kivity
2011-12-22 12:35 ` [patch 0/3] RFC: provide synchronous registers in kvm_run Avi Kivity
2011-12-22 12:49   ` Christian Borntraeger
2011-12-22 12:54     ` Avi Kivity
2011-12-22 13:17       ` Christian Borntraeger
2011-12-22 13:25         ` Avi Kivity
     [not found] ` <1325605858-30492-1-git-send-email-borntraeger@de.ibm.com>
     [not found]   ` <1325605858-30492-4-git-send-email-borntraeger@de.ibm.com>
2012-01-04  8:16     ` [PATCH 3/3] kvm-s390: provide standard guest registers via kvm_run Heiko Carstens
2012-01-04  8:30       ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EF32509.80200@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=agraf@suse.de \
    --cc=avi@redhat.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=cotte@de.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=jfrei@linux.vnet.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.