Re: [PATCH] rpcbind: add support for systemd socket activation

["Cristian Rodríguez" <crrodriguez@opensuse.org>]

On 22/12/11 22:05, Tom Gundersen wrote:
> Making rpcbind sockect activated will greatly simplify
> its integration in systemd systems. In essence, other services
> may now assume that rpcbind is always available, even during very
> early boot. This means that we no longer need to worry about any
> ordering dependencies.
>
> This is based on a patch originally posted by Lennart Poettering:
> <http://permalink.gmane.org/gmane.linux.nfs/33774>.
>
> That patch was not merged due to the lack of a shared library and
> as systemd was seen to be too Fedora specific.
>
> Systemd now provides a shared library, and it is shipped by defalt in
> OpenSUSE in addition to Fedora, and it is available in Debain, Gentoo,
> Arch, and others.
>
> This version of the patch has three changes from the original:
>
>   * It uses the shared library.
>   * It comes with unit files.
>   * It is rebased on top of master.
>
> Please review the patch with "git show -b" or otherwise ignoring the
> whitespace changes, or it will be extremely difficult to read.
>
> Comments welcome.
>
> v2: correctly enable systemd code at compile time
>      handle the case where not all the required sockets were supplied
>      listen on udp/tcp port 111 in addition to /var/run/rpcbind.sock
>      do not daemonize
>
> Original-patch-by: Lennart Poettering<lennart@poettering.net>
> Cc: Steve Dickson<steved@redhat.com>
> Cc: systemd-devel@lists.freedesktop.org
> Cc: Cristian Rodríguez<crrodriguez@opensuse.org>
> Signed-off-by: Tom Gundersen<teg@jklm.no>
> ---
>
> Thanks to Cristian for testing. The testcase I had been using was entirely flawed,
> the code did in fact not work at all. Sorry about that!

ACKed: Cristian Rodríguez<crrodriguez@opensuse.org>

This version works as expected here.