From: Paolo Bonzini <pbonzini@redhat.com>
To: ronnie sahlberg <ronniesahlberg@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI
Date: Fri, 23 Dec 2011 10:08:11 +0100 [thread overview]
Message-ID: <4EF444FB.4030903@redhat.com> (raw)
In-Reply-To: <CAN05THTbnZdjweJz5NLk7OsHMnNJJnY=kXoUi56pabsfijvRtA@mail.gmail.com>
On 12/22/2011 09:51 PM, ronnie sahlberg wrote:
> The difference between qcow2 and iscsi and the problem is that .open()
> is called for all devices before the monitor is started, so .open() is
> called before we would have a chance to even hand the password to
> qemu.
>
> For qcow2 this is not a problem since even if the file is password
> protected the file header is not, so you can still open the file and
> read the header (to discover it is password protected) without knowing
> the password.
> So qcow2 can still open the file and do all the sanity checks it needs
> without yet knowing the password.
You're right.
I see that the libvirt driver for rbd simply passes it on the command
line. I hope I'll be able to review the patch further today.
Paolo
next prev parent reply other threads:[~2011-12-23 9:08 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-18 4:48 [Qemu-devel] Patch to add iSCSI configuration optionsi. Version 2 Ronnie Sahlberg
2011-12-18 4:48 ` [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI Ronnie Sahlberg
2011-12-18 13:48 ` Paolo Bonzini
2011-12-22 20:51 ` ronnie sahlberg
2011-12-23 9:08 ` Paolo Bonzini [this message]
2011-12-23 9:54 ` ronnie sahlberg
2012-01-03 10:12 ` Daniel P. Berrange
2012-01-19 12:17 ` Kevin Wolf
2012-01-20 8:58 ` ronnie sahlberg
2012-01-20 9:34 ` Kevin Wolf
-- strict thread matches above, loose matches on Subject: below --
2012-01-25 22:39 [Qemu-devel] [PATCH 0/0] Add " Ronnie Sahlberg
2012-01-25 22:39 ` [Qemu-devel] [PATCH] iSCSI: add " Ronnie Sahlberg
2012-01-25 22:53 ` Eric Blake
2012-01-26 10:58 ` Kevin Wolf
2012-01-21 10:03 [Qemu-devel] [PATCH] Add configuration variables for iscsi Ronnie Sahlberg
2012-01-21 10:03 ` [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI Ronnie Sahlberg
2012-01-23 18:07 ` Eric Blake
2012-01-25 6:47 ` ronnie sahlberg
2012-01-25 15:57 ` Eric Blake
2012-01-25 22:17 ` ronnie sahlberg
2012-01-26 9:08 ` Kevin Wolf
2012-01-26 9:18 ` ronnie sahlberg
2012-01-26 9:27 ` Kevin Wolf
2012-01-26 9:54 ` ronnie sahlberg
2012-01-26 14:55 ` Michael Tokarev
2012-01-26 16:08 ` Michael Tokarev
2012-01-26 15:01 ` Daniel P. Berrange
2012-01-26 9:50 ` Michael Tokarev
2011-11-26 23:24 [Qemu-devel] Patch to add iSCSI configuration options Ronnie Sahlberg
2011-11-26 23:24 ` [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI Ronnie Sahlberg
2011-11-27 8:47 ` Orit Wasserman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF444FB.4030903@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.