From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Re2tR-0007Tl-Ua for mharc-grub-devel@gnu.org; Fri, 23 Dec 2011 06:02:29 -0500 Received: from eggs.gnu.org ([140.186.70.92]:34716) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Re2tM-0007Ta-8u for grub-devel@gnu.org; Fri, 23 Dec 2011 06:02:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Re2tL-00082Q-2x for grub-devel@gnu.org; Fri, 23 Dec 2011 06:02:24 -0500 Received: from mail-ww0-f49.google.com ([74.125.82.49]:37990) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Re2tK-00082G-Ur for grub-devel@gnu.org; Fri, 23 Dec 2011 06:02:23 -0500 Received: by wgbdt11 with SMTP id dt11so13793568wgb.30 for ; Fri, 23 Dec 2011 03:02:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=Adk330RBjuynnA7AM8sT0QSwmGyZDj/0Jy71CrVa8P4=; b=tV84nZ7koxZa3+oliqg3t50rsVozdKmmBVujZ46B/dO5FTDkYIyFjOAiA389ETemBK 0pTUkRYxqGPcc5lHORw87FzhM2JztZMFdq+0a8b49OD+EKf3mvtBqnI5UdwzSaJGiAqK qHkfGzT7py8rmlbjdU6aE1tpf2JqkF4qrhR9U= Received: by 10.216.134.162 with SMTP id s34mr7872447wei.59.1324638142150; Fri, 23 Dec 2011 03:02:22 -0800 (PST) Received: from debian.x201.phnet (77-234.197-178.cust.bluewin.ch. [178.197.234.77]) by mx.google.com with ESMTPS id di5sm30573629wib.3.2011.12.23.03.02.19 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 23 Dec 2011 03:02:20 -0800 (PST) Message-ID: <4EF45FB8.5070103@gmail.com> Date: Fri, 23 Dec 2011 12:02:16 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111114 Icedove/3.1.16 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: Remove the usage of "local" in scripts introduces a small bug in "version_test_gt()" References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 74.125.82.49 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2011 11:02:28 -0000 Committed, thanks. Next time please include Changelog entry and make sure that your patch isn't word-wrapped by your mailer. On 28.11.2011 10:08, Lukas Anzinger wrote: > Hi, > > it looks to me that the patch which removes the usage of "local" in > scripts (http://lists.gnu.org/archive/html/grub-devel/2011-11/msg00037.html) > introduces a bug in the function version_test_gt() in the file > util/grub-mkconfig_lib.in: > > The variable $cmp is set to "gt" or "ge", however, > $version_test_gt_cmp is used instead and the case has no effect. > > This patch should fix it: > > --- a/util/grub-mkconfig_lib.in 2011-11-28 09:42:11.000000000 +0100 > +++ b/util/grub-mkconfig_lib.in 2011-11-28 10:00:00.000000000 +0100 > @@ -198,8 +198,8 @@ > fi > case "$version_test_gt_a:$version_test_gt_b" in > *.old:*.old) ;; > - *.old:*) version_test_gt_a="`echo -n "$version_test_gt_a" | sed > -e 's/\.old$//'`" ; cmp=gt ;; > - *:*.old) version_test_gt_b="`echo -n "$version_test_gt_b" | sed > -e 's/\.old$//'`" ; cmp=ge ;; > + *.old:*) version_test_gt_a="`echo -n "$version_test_gt_a" | sed > -e 's/\.old$//'`" ; version_test_gt_cmp=gt ;; > + *:*.old) version_test_gt_b="`echo -n "$version_test_gt_b" | sed > -e 's/\.old$//'`" ; version_test_gt_cmp=ge ;; > esac > version_test_numeric "$version_test_gt_a" "$version_test_gt_cmp" > "$version_test_gt_b" > return "$?" > > I noticed the problem when I tried to apply the patch > "dpkg_version_comparison.patch" from Debian. > > Maybe someone should take a look at the other variables ... > > Regards, > > Lukas > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel > -- Regards Vladimir 'φ-coder/phcoder' Serbinenko