Re: [Cocci] [PATCH 2/2] coccinelle: Add patch for replacing open-coded IS_ERR_OR_NULL

[Lars-Peter Clausen <lars@metafoo.de>]

On 12/21/2011 01:10 PM, Julia Lawall wrote:
> On Wed, 21 Dec 2011, Lars-Peter Clausen wrote:
> 
>> On 12/20/2011 11:24 PM, Julia Lawall wrote:
>>> For this one, I made quite a number of changes, some of which required
>>> fixing a bug in Coccinelle...  I will try to release the bug fix
>>> shortly. In general, though, I have added ... between the two tests.  I
>>> also got rid of the focus on ifs in the org and report rules.
>>>
>>
>> Ok, thanks. Was the removing of the ifs in related to the Coccinelle
>> bug? I
>> always get an error if I start a match with a conditional.
> 
> Not at all.  The bug was that a patterm like:
> 
>  @depends on patch@
>  expression x;
>  @@
>  - IS_ERR(x)
>  + IS_ERR_OR_NULL(x)
>    || ...
>  - || x == NULL
> 
> thought that it should be applied in two ways, giving an error about a
> double transformation of the IS_ERR call.
> 
> Could you reproduce the example that caused problems?

Hm, I can reproduce it anymore, even with my original patch, must have been
caused by some other error I had in the semantic patch at that time.

- Lars