From: Christian Inci <chris.pcguy.inci@gmail.com>
To: linux-pci@vger.kernel.org
Subject: [PATCH]: fix for a bash issue regarding a variable in update-pciids (try 2)
Date: Fri, 23 Dec 2011 18:13:45 +0100 [thread overview]
Message-ID: <4EF4B6C9.3090803@gmail.com> (raw)
>From ced082632d496645736f245b6a6482bdbf267579 Mon Sep 17 00:00:00 2001
From: Christian Inci <chris.pcguy.inci@gmail.com>
Date: Fri, 23 Dec 2011 17:24:56 +0100
Subject: [PATCH]: fix for a bash issue regarding a variable ... (try 2)
in update-pciids At least some bash versions can and
will complain about an empty PCI_COMPRESSED_IDS variable,
when it get used in the 'if'-statement.
Try 2: change the comparison operand instead of the value.
Many thanks to Martin Mares <mj@ucw.cz> for the hint.
Signed-off-by: Christian Inci <chris.pcguy.inci@gmail.com>
---
update-pciids.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/update-pciids.sh b/update-pciids.sh
index 5e77109..51397f1 100755
--- a/update-pciids.sh
+++ b/update-pciids.sh
@@ -15,7 +15,7 @@ if ! touch ${DEST} >/dev/null 2>&1 ; then
exit 1
fi
-if [ "$PCI_COMPRESSED_IDS" -eq 1 ] ; then
+if [ "$PCI_COMPRESSED_IDS" == 1 ] ; then
DECOMP="cat"
SRC="$SRC.gz"
GREP=zgrep
--
1.7.7.4
reply other threads:[~2011-12-23 17:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF4B6C9.3090803@gmail.com \
--to=chris.pcguy.inci@gmail.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.