All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jehan Bing <jehan@orb.com>
To: git@vger.kernel.org
Subject: Re: "Nested quantifiers" error in gitweb with "++" in the filename
Date: Fri, 23 Dec 2011 11:37:23 -0800	[thread overview]
Message-ID: <4EF4D873.4090803@orb.com> (raw)
In-Reply-To: <CANgJU+VA9s9t0c8D0P_DesbSDQRBQ6v913KixKQAuiy8jZsdzQ@mail.gmail.com>

On 2011-12-23 08:02, demerphq wrote:
> On 22 December 2011 21:37, Jehan Bing<jehan@orb.com>  wrote:
>> Hi,
>>
>> I'm getting an error when trying to look at a blob when the filename has
>> "++" in it:
>>
>> http://.../blob/13ec1624fefc23d20d0407aac3337b35844a2ceb:/foo-++.txt
>
> This error comes because the filename is being used a pattern without
> being protected by a quotemeta.
>
> Interestingly, a later version of perl would not have this problem as
> ++ is a legal quantifier as of 5.10, nevertheless it probably wouldnt
> do what you expected.
>

Interestingly, a later version of perl would not have this problem as, 
after investigating the problem further, it's actually a bug in CGI.pm 
which has since been fixed ;)

My distribution comes with an old version of CGI.pm (3.15 from perl 
5.8.8). After updating to the latest, the problem went away.

      reply	other threads:[~2011-12-23 19:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-22 20:37 "Nested quantifiers" error in gitweb with "++" in the filename Jehan Bing
2011-12-23 16:02 ` demerphq
2011-12-23 19:37   ` Jehan Bing [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EF4D873.4090803@orb.com \
    --to=jehan@orb.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.