From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59793) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ReNn0-0008EW-24 for qemu-devel@nongnu.org; Sat, 24 Dec 2011 04:21:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ReNmy-0006SF-Sh for qemu-devel@nongnu.org; Sat, 24 Dec 2011 04:21:14 -0500 Received: from cantor2.suse.de ([195.135.220.15]:57057 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ReNmy-0006S4-M6 for qemu-devel@nongnu.org; Sat, 24 Dec 2011 04:21:12 -0500 Message-ID: <4EF5993F.5040107@suse.de> Date: Sat, 24 Dec 2011 10:19:59 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1324578014-24746-1-git-send-email-mark.langsdorf@calxeda.com> <1324578014-24746-3-git-send-email-mark.langsdorf@calxeda.com> In-Reply-To: <1324578014-24746-3-git-send-email-mark.langsdorf@calxeda.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 2/9] arm: Set frequencies for arm_timer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Langsdorf Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org, paul@codesourcery.com Am 22.12.2011 19:20, schrieb Mark Langsdorf: > Use qdev properties to allow board modelers to set the frequencies > for the sp804 timer. Each of the sp804's timers can have an > individual frequency. The timers default to 1MHz. >=20 > Signed-off-by: Mark Langsdorf > --- > Changes from v1 > Simplified multiple timer frequency handling > Removed the shared default > hw/arm_timer.c | 26 +++++++++++++++++++++----- > 1 files changed, 21 insertions(+), 5 deletions(-) >=20 > diff --git a/hw/arm_timer.c b/hw/arm_timer.c > index 0a5b9d2..d2738c7 100644 > --- a/hw/arm_timer.c > +++ b/hw/arm_timer.c > @@ -178,6 +180,7 @@ typedef struct { > SysBusDevice busdev; > MemoryRegion iomem; > arm_timer_state *timer[2]; > + int freq0, freq1; > int level[2]; > qemu_irq irq; > } sp804_state; > @@ -281,6 +287,16 @@ static int sp804_init(SysBusDevice *dev) > return 0; > } > =20 > +static SysBusDeviceInfo sp804_info =3D { > + .init =3D sp804_init, > + .qdev.name =3D "sp804", > + .qdev.size =3D sizeof(sp804_state), > + .qdev.props =3D (Property[]) { > + DEFINE_PROP_INT32("freq0", sp804_state, freq0, 1000000), > + DEFINE_PROP_INT32("freq1", sp804_state, freq1, 1000000), Since you're using INT32 here, please declare it as int32_t above. Or uint32_t and UINT32 if there's no negative frequency. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg