From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org, takuya.yoshikawa@gmail.com
Subject: Re: [PATCH 2/3] KVM: MMU: Add missing large page accounting to drop_large_spte()
Date: Mon, 26 Dec 2011 15:11:56 +0200 [thread overview]
Message-ID: <4EF8729C.9000806@redhat.com> (raw)
In-Reply-To: <4EF01103.4060702@oss.ntt.co.jp>
On 12/20/2011 06:37 AM, Takuya Yoshikawa wrote:
> ping
>
> (2011/11/29 14:03), Takuya Yoshikawa wrote:
>> Signed-off-by: Takuya Yoshikawa<yoshikawa.takuya@oss.ntt.co.jp>
>> ---
>> arch/x86/kvm/mmu.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
>> index 09da963..5e761ff 100644
>> --- a/arch/x86/kvm/mmu.c
>> +++ b/arch/x86/kvm/mmu.c
>> @@ -1803,6 +1803,7 @@ static void drop_large_spte(struct kvm_vcpu
>> *vcpu, u64 *sptep)
>> {
>> if (is_large_pte(*sptep)) {
>> drop_spte(vcpu->kvm, sptep);
>> + --vcpu->kvm->stat.lpages;
>> kvm_flush_remote_tlbs(vcpu->kvm);
>> }
>> }
>
> Is this fix wrong?
>
> I do not mind dropping other two cleanups in the patch set
> if you do not like; of course I will update this if needed.
>
Sorry, missed it. It's not wrong, applied it and patch 1.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-12-26 13:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 5:01 [PATCH 0/3] KVM: MMU: Trivial fix and cleanups Takuya Yoshikawa
2011-11-29 5:02 ` [PATCH 1/3] KVM: MMU: Remove for_each_unsync_children() macro Takuya Yoshikawa
2011-11-29 5:03 ` [PATCH 2/3] KVM: MMU: Add missing large page accounting to drop_large_spte() Takuya Yoshikawa
2011-12-20 4:37 ` Takuya Yoshikawa
2011-12-26 13:11 ` Avi Kivity [this message]
2011-11-29 5:04 ` [PATCH 3/3] KVM: MMU: Make drop_large_spte() more generic Takuya Yoshikawa
2011-12-26 13:15 ` Avi Kivity
2011-12-26 13:17 ` [PATCH 0/3] KVM: MMU: Trivial fix and cleanups Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF8729C.9000806@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=takuya.yoshikawa@gmail.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.