From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42770) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RfWp6-0003CO-LG for qemu-devel@nongnu.org; Tue, 27 Dec 2011 08:12:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RfWp5-00066b-1o for qemu-devel@nongnu.org; Tue, 27 Dec 2011 08:12:08 -0500 Received: from cantor2.suse.de ([195.135.220.15]:43258 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RfWp4-00066P-Lt for qemu-devel@nongnu.org; Tue, 27 Dec 2011 08:12:06 -0500 Message-ID: <4EF9C3D7.4070008@suse.de> Date: Tue, 27 Dec 2011 14:10:47 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1324893824-13558-1-git-send-email-i.mitsyanko@samsung.com> <1324893824-13558-2-git-send-email-i.mitsyanko@samsung.com> <4EF97DBA.9040604@samsung.com> In-Reply-To: <4EF97DBA.9040604@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/3] vmstate: introduce calc_size VMStateField List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: i.mitsyanko@samsung.com Cc: Peter Maydell , qemu-devel@nongnu.org, Juan Quintela Am 27.12.2011 09:11, schrieb Mitsyanko Igor: > On 12/26/2011 07:20 PM, Peter Maydell wrote: >> On 26 December 2011 10:03, Mitsyanko Igor=20 >> wrote: >>> diff --git a/hw/hw.h b/hw/hw.h >>> index efa04d1..8ce4475 100644 >>> --- a/hw/hw.h >>> +++ b/hw/hw.h >>> @@ -303,9 +303,9 @@ enum VMStateFlags { >>> VMS_ARRAY_OF_POINTER =3D 0x040, >>> VMS_VARRAY_UINT16 =3D 0x080, /* Array with size in uint16_t >>> field */ >>> VMS_VBUFFER =3D 0x100, /* Buffer with size in int32_t >>> field */ >>> - VMS_MULTIPLY =3D 0x200, /* multiply "size" field by >>> field_size */ >>> - VMS_VARRAY_UINT8 =3D 0x400, /* Array with size in uint8_t >>> field*/ >>> - VMS_VARRAY_UINT32 =3D 0x800, /* Array with size in uint32_t >>> field*/ >>> + VMS_CALC_SIZE =3D 0x200, /* calculate size of dynamic >>> buffer */ >>> + VMS_VARRAY_UINT8 =3D 0x400, /* Array with size in uint8_t >>> field */ >>> + VMS_VARRAY_UINT32 =3D 0x800, /* Array with size in uint32_t >>> field */ >> >> These unrelated whitespace fixes are confusing -- please drop them. > QEMU wiki here http://wiki.qemu.org/Contribute/SubmitAPatch states that > it's ok :) >> It's OK to fix coding style issues in the immediate area (few lines) > > of the lines you're changing.) It's not really a Coding Style issue though (just an aesthetic one), what's meant by the quote is to fix braces around the lines you touch. I'd suggest to put it in a separate preceding patch, then it gets fixed and we can still better see what you're changing here. (I'm in need of a mechanism like this for AHCI so please cc Juan and me on v2 of this patch.) Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg