From: Avi Kivity <avi@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Mitsyanko Igor <i.mitsyanko@samsung.com>,
e.voevodin@samsung.com, Juan Quintela <quintela@redhat.com>,
qemu-devel@nongnu.org, kyungmin.park@samsung.com,
d.solodkiy@samsung.com, m.kozlov@samsung.com,
jehyung.lee@samsung.com
Subject: Re: [Qemu-devel] [PATCH 2/3] hw/sd.c: add SD card save/load support
Date: Tue, 27 Dec 2011 16:13:46 +0200 [thread overview]
Message-ID: <4EF9D29A.5030409@redhat.com> (raw)
In-Reply-To: <CAFEAcA-6JD8rQd_RYFmxaPO2jdZS2bzY--eCmgp2Nc=XcCAdSg@mail.gmail.com>
On 12/26/2011 04:58 PM, Peter Maydell wrote:
> >
> > void sd_enable(SDState *sd, int enable)
> > {
> > - sd->enable = enable;
> > + sd->enable = enable ? true : false;
>
> This kind of thing is why I don't like bool :-)
/me leaps to bool's defence:
sd->enable = enable should work just fine. The assignment is
equivalent to sd->enable = enable != 0, as conversion to bool coerces
the value to true/false.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-12-27 14:13 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-26 10:03 [Qemu-devel] [PATCH 0/3] Improve SD controllers emulation Mitsyanko Igor
2011-12-26 10:03 ` [Qemu-devel] [PATCH 1/3] vmstate: introduce calc_size VMStateField Mitsyanko Igor
2011-12-26 15:20 ` Peter Maydell
2011-12-27 8:11 ` Mitsyanko Igor
2011-12-27 13:10 ` Andreas Färber
2011-12-28 7:41 ` Mitsyanko Igor
2011-12-27 7:54 ` [Qemu-devel] [PATCH V2 1/3] vmstate: introduce get_bufsize entry in VMStateField Mitsyanko Igor
2011-12-26 10:03 ` [Qemu-devel] [PATCH 2/3] hw/sd.c: add SD card save/load support Mitsyanko Igor
2011-12-26 14:58 ` Peter Maydell
2011-12-27 11:27 ` Mitsyanko Igor
2011-12-27 13:27 ` Andreas Färber
2011-12-27 13:54 ` Mitsyanko Igor
2011-12-27 14:13 ` Avi Kivity [this message]
2011-12-27 21:30 ` Peter Maydell
2011-12-28 9:50 ` Avi Kivity
2011-12-26 10:03 ` [Qemu-devel] [PATCH 3/3] hw/: Introduce spec. ver. 2.00 compliant SD host controller Mitsyanko Igor
2011-12-26 11:35 ` malc
2011-12-28 12:08 ` [Qemu-devel] [PATCH V2 0/3] Improve SD controllers emulation Mitsyanko Igor
2011-12-28 12:08 ` [Qemu-devel] [PATCH V2 1/3] vmstate: introduce get_bufsize entry in VMStateField Mitsyanko Igor
2011-12-28 12:08 ` [Qemu-devel] [PATCH V2 2/3] hw/sd.c: add SD card save/load support Mitsyanko Igor
2011-12-28 13:26 ` Peter Maydell
2011-12-28 14:02 ` Mitsyanko Igor
2011-12-28 14:41 ` Peter Maydell
2011-12-28 12:08 ` [Qemu-devel] [PATCH V2 3/3] hw: Introduce spec. ver. 2.00 compliant SD host controller Mitsyanko Igor
2011-12-28 15:32 ` [Qemu-devel] [PATCH V3 0/5] Improve SD controllers emulation Mitsyanko Igor
2011-12-28 15:32 ` [Qemu-devel] [PATCH V3 1/5] vmstate: introduce get_bufsize entry in VMStateField Mitsyanko Igor
2012-01-19 13:40 ` Andreas Färber
2011-12-28 15:32 ` [Qemu-devel] [PATCH V3 2/5] hw/sd.c: add SD card save/load support Mitsyanko Igor
2011-12-28 15:32 ` [Qemu-devel] [PATCH V3 3/5] hw/sd.c: convert wp_groups, expecting_acmd and enable to bool Mitsyanko Igor
2011-12-28 15:32 ` [Qemu-devel] [PATCH V3 4/5] hw/sd.c: convert wp_switch and spi " Mitsyanko Igor
2011-12-28 15:32 ` [Qemu-devel] [PATCH V3 5/5] hw: Introduce spec. ver. 2.00 compliant SD host controller Mitsyanko Igor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF9D29A.5030409@redhat.com \
--to=avi@redhat.com \
--cc=d.solodkiy@samsung.com \
--cc=e.voevodin@samsung.com \
--cc=i.mitsyanko@samsung.com \
--cc=jehyung.lee@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=m.kozlov@samsung.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.