All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
	sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH] of/pdt: fix section mismatch warning
Date: Tue, 27 Dec 2011 16:54:07 -0600	[thread overview]
Message-ID: <4EFA4C8F.5080901@gmail.com> (raw)
In-Reply-To: <20111227.172921.750063350996279524.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>

On 12/27/2011 04:29 PM, David Miller wrote:
> From: Sam Ravnborg <sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
> Date: Tue, 27 Dec 2011 23:26:58 +0100
> 
>> We have two implementations of kernel_tree_alloc() - one in fdt.c and
>> another in pdt.c.
>>
>> $ grep kernel_tree_alloc *
>> fdt.c:static void *kernel_tree_alloc(u64 size, u64 align)
>> fdt.c:  __unflatten_device_tree(device_tree, mynodes, &kernel_tree_alloc);
>> pdt.c:static void * __init kernel_tree_alloc(u64 size, u64 align)
>> pdt.c:  of_alias_scan(kernel_tree_alloc);
>>
>> The version in fdt.c is using kzalloc() whereas the version in pdt.c
>> uses prom_early_alloc().
>>
>> And of_fdt_unflatten_tree() uses the version in fdt.c - so the patch is OK.
>>
>> It is confusing that they have the same name - but I did nto fix that.
>> And I forgot about this detail when I wrote the changelog.
> 
> Ok, I hadn't realized this, thanks for explaining.
> 
> I think Grant should apply your patch then:
> 
> Acked-by: David S. Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
> _______________________________________________

I've applied it for 3.3 unless you think it needs to go into 3.2.

Rob

  parent reply	other threads:[~2011-12-27 22:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-27 22:04 [PATCH] of/pdt: fix section mismatch warning Sam Ravnborg
     [not found] ` <20111227220408.GA18932-OoSGOWW0KRunlFQ6Q1D1Y0B+6BGkLq7r@public.gmane.org>
2011-12-27 22:13   ` David Miller
     [not found]     ` <20111227.171307.1727824866350984198.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2011-12-27 22:26       ` Sam Ravnborg
     [not found]         ` <20111227222658.GA19202-OoSGOWW0KRunlFQ6Q1D1Y0B+6BGkLq7r@public.gmane.org>
2011-12-27 22:29           ` David Miller
     [not found]             ` <20111227.172921.750063350996279524.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2011-12-27 22:54               ` Rob Herring [this message]
     [not found]                 ` <4EFA4C8F.5080901-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-12-27 23:03                   ` David Miller
2011-12-27 23:07                   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EFA4C8F.5080901@gmail.com \
    --to=robherring2-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.