From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rfo8c-0008J5-8F for qemu-devel@nongnu.org; Wed, 28 Dec 2011 02:41:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rfo8b-0002Fb-4K for qemu-devel@nongnu.org; Wed, 28 Dec 2011 02:41:26 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:62872) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rfo8a-0002FO-W0 for qemu-devel@nongnu.org; Wed, 28 Dec 2011 02:41:25 -0500 Received: from euspt2 (mailout1.w1.samsung.com [210.118.77.11]) by mailout1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTP id <0LWW009USLCX9Q@mailout1.w1.samsung.com> for qemu-devel@nongnu.org; Wed, 28 Dec 2011 07:41:21 +0000 (GMT) Received: from [106.109.8.52] by spt2.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0LWW00E6ALCW18@spt2.w1.samsung.com> for qemu-devel@nongnu.org; Wed, 28 Dec 2011 07:41:21 +0000 (GMT) Date: Wed, 28 Dec 2011 11:41:19 +0400 From: Mitsyanko Igor In-reply-to: <4EF9C3D7.4070008@suse.de> Message-id: <4EFAC81F.8050004@samsung.com> MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=UTF-8 Content-transfer-encoding: QUOTED-PRINTABLE References: <1324893824-13558-1-git-send-email-i.mitsyanko@samsung.com> <1324893824-13558-2-git-send-email-i.mitsyanko@samsung.com> <4EF97DBA.9040604@samsung.com> <4EF9C3D7.4070008@suse.de> Subject: Re: [Qemu-devel] [PATCH 1/3] vmstate: introduce calc_size VMStateField Reply-To: i.mitsyanko@samsung.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , e.voevodin@samsung.com, Juan Quintela , kyungmin.park@samsung.com, d.solodkiy@samsung.com, Paolo Bonzini , m.kozlov@samsung.com, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= On 12/27/2011 05:10 PM, Andreas F=C3=A4rber wrote: > Am 27.12.2011 09:11, schrieb Mitsyanko Igor: >> On 12/26/2011 07:20 PM, Peter Maydell wrote: >>> On 26 December 2011 10:03, Mitsyanko Igor >>> wrote: >>>> diff --git a/hw/hw.h b/hw/hw.h >>>> index efa04d1..8ce4475 100644 >>>> --- a/hw/hw.h >>>> +++ b/hw/hw.h >>>> @@ -303,9 +303,9 @@ enum VMStateFlags { >>>> VMS_ARRAY_OF_POINTER =3D 0x040, >>>> VMS_VARRAY_UINT16 =3D 0x080, /* Array with size in uin= t16_t >>>> field */ >>>> VMS_VBUFFER =3D 0x100, /* Buffer with size in in= t32_t >>>> field */ >>>> - VMS_MULTIPLY =3D 0x200, /* multiply "size" field b= y >>>> field_size */ >>>> - VMS_VARRAY_UINT8 =3D 0x400, /* Array with size in uint= 8_t >>>> field*/ >>>> - VMS_VARRAY_UINT32 =3D 0x800, /* Array with size in uint= 32_t >>>> field*/ >>>> + VMS_CALC_SIZE =3D 0x200, /* calculate size of dynam= ic >>>> buffer */ >>>> + VMS_VARRAY_UINT8 =3D 0x400, /* Array with size in uint= 8_t >>>> field */ >>>> + VMS_VARRAY_UINT32 =3D 0x800, /* Array with size in uint= 32_t >>>> field */ >>> >>> These unrelated whitespace fixes are confusing -- please drop the= m. >> QEMU wiki here http://wiki.qemu.org/Contribute/SubmitAPatch states= that >> it's ok :) >>> It's OK to fix coding style issues in the immediate area (few lin= es)> >> of the lines you're changing.) > > It's not really a Coding Style issue though (just an aesthetic one)= , > what's meant by the quote is to fix braces around the lines you tou= ch. > > I'd suggest to put it in a separate preceding patch, then it gets f= ixed > and we can still better see what you're changing here. If v2 of this patch will be accepted and we will drop VMS_MULTIPLY, I could add required spaces together with changing values given to=20 VMS_VARRAY_UINT8 and VMS_VARRAY_UINT32 flags. Or this can be done by= =20 Paolo Bonzini in his "split hw/hw.h" patch, I cc him just in case he= =20 wouldn't mind to do this. > (I'm in need of a mechanism like this for AHCI so please cc Juan an= d me > on v2 of this patch.) > > Andreas > I'm also considering to change local size variable in=20 vmstate_load_state() and vmstate_save_state() to size_t, it makes no= =20 sense to convert size_t field->size to intermediate int type just to= =20 pass it again as size_t to get() function. --=20 Mitsyanko Igor ASWG, Moscow R&D center, Samsung Electronics email: i.mitsyanko@samsung.com