From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takuya Yoshikawa Subject: Re: [PATCH v6] kvm: make vcpu life cycle separated from kvm instance Date: Wed, 28 Dec 2011 19:19:26 +0900 Message-ID: <4EFAED2E.6090403@oss.ntt.co.jp> References: <1324091975-20930-1-git-send-email-kernelfans@gmail.com> <1324975139-8836-1-git-send-email-kernelfans@gmail.com> <4EFAE72D.3080609@redhat.com> <4EFAE74F.7000200@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Liu Ping Fan , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, aliguori@us.ibm.com, gleb@redhat.com, mtosatti@redhat.com, xiaoguangrong.eric@gmail.com, jan.kiszka@web.de, Takuya Yoshikawa To: Avi Kivity Return-path: In-Reply-To: <4EFAE74F.7000200@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org (2011/12/28 18:54), Avi Kivity wrote: > On 12/28/2011 11:53 AM, Avi Kivity wrote: >> On 12/27/2011 10:38 AM, Liu Ping Fan wrote: >>> From: Liu Ping Fan >>> >>> Currently, vcpu can be destructed only when kvm instance destroyed. >>> Change this to vcpu's destruction before kvm instance, so vcpu MUST >>> and CAN be destroyed before kvm's destroy. >>> >>> Signed-off-by: Liu Ping Fan >>> --- >>> arch/x86/kvm/i8254.c | 10 +++-- >>> arch/x86/kvm/i8259.c | 17 +++++-- >>> arch/x86/kvm/x86.c | 53 +++++++++++----------- >>> include/linux/kvm_host.h | 20 +++----- >>> virt/kvm/irq_comm.c | 6 ++- >>> virt/kvm/kvm_main.c | 110 +++++++++++++++++++++++++++++++++++----------- >>> >> >> Documentation/virtual/kvm/api.txt >> > > Oops, that's only needed when the unplug API is introduced. > I think it is OK to to add such an API later on, but I really want the author to write the plan in the changelog. Otherwise people not belonging to Red Hat or IBM cannot know what this commit is aiming at. I am not objecting to this patch itself, but the way this kind of change is being introduced seems not be in a good manner. Takuya