From: Pavel Emelyanov <xemul@parallels.com>
To: David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 3/5] inet_diag: Extend the meminfo report
Date: Wed, 28 Dec 2011 22:58:57 +0400 [thread overview]
Message-ID: <4EFB66F1.3020702@parallels.com> (raw)
In-Reply-To: <20111228.134553.1005758963166343587.davem@davemloft.net>
On 12/28/2011 10:45 PM, David Miller wrote:
> From: Pavel Emelyanov <xemul@parallels.com>
> Date: Wed, 28 Dec 2011 17:38:40 +0400
>
>> Add the backlog length and wmem and rmem buffers limits.
>> With this the TCP memory info is full and can be analyzed.
>>
>> Few words about extending the existing structure. The nla engine stores lengths of
>> fields and the nla parser will parse the new format successfully (checked on the ss
>> tool). But new apps will have to take this field's length into account. Hopefully
>> this is acceptable price for not introducing another ext bit and structure.
>>
>> Singed-off-by: Pavel Emelyanov <xemul@parallels.com>
>
> I think you'll need to add a new extension, rather than create this incompatability.
>
OK, I will, but I seem to misunderstand the NLA's length value then. My impression is
that it was introduced to make it possible to put the payload of different length,
probably adding more stuff at the end.
If I'm wrong about it, what is the real purpose of this field? _Only_ to make nla_parse
jump on the "generic" offsets?
Thanks,
Pavel
next prev parent reply other threads:[~2011-12-28 18:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-28 13:38 [PATCH 3/5] inet_diag: Extend the meminfo report Pavel Emelyanov
2011-12-28 18:45 ` David Miller
2011-12-28 18:58 ` Pavel Emelyanov [this message]
2011-12-28 19:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EFB66F1.3020702@parallels.com \
--to=xemul@parallels.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.