From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 3/3] gprs: Use netreg SPN watch API
Date: Wed, 28 Dec 2011 16:14:34 -0600 [thread overview]
Message-ID: <4EFB94CA.1000001@gmail.com> (raw)
In-Reply-To: <1325078324-30548-4-git-send-email-oleg.zhurakivskyy@intel.com>
[-- Attachment #1: Type: text/plain, Size: 597 bytes --]
Hi Oleg,
On 12/28/2011 07:18 AM, Oleg Zhurakivskyy wrote:
> ---
> src/gprs.c | 67 ++++++++++++++++++++++++++++++++---------------------------
> 1 files changed, 36 insertions(+), 31 deletions(-)
>
So I like this approach, the only problem is that netreg atom is a
post_online atom and gprs is post_sim atom. This means that if no
contexts are provisioned we must wait for the netreg atom to be
registered. This leads to a slight asymmetry in the API.
Perhaps we should move the SPN logic to the sim atom and make netreg and
gprs atom simple consumers?
Regards,
-Denis
next prev parent reply other threads:[~2011-12-28 22:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-28 13:18 [PATCH 0/3] Unify SPN reading logic in src/gprs.c Oleg Zhurakivskyy
2011-12-28 13:18 ` [PATCH 1/3] gprs: Minor whitespace and style fixes Oleg Zhurakivskyy
2011-12-28 22:08 ` Denis Kenzior
2011-12-28 13:18 ` [PATCH 2/3] network: Add SPN watch capability Oleg Zhurakivskyy
2011-12-28 13:18 ` [PATCH 3/3] gprs: Use netreg SPN watch API Oleg Zhurakivskyy
2011-12-28 22:14 ` Denis Kenzior [this message]
2011-12-30 8:43 ` Oleg Zhurakivskyy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EFB94CA.1000001@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.