From: "Richard Schütz" <r.schtz@t-online.de>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: David Herrmann <dh.herrmann@googlemail.com>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Andrzej Prochyra <andrzej@prochyra.name>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, "Zhang, Rui" <rui.zhang@intel.com>
Subject: Re: [PATCH] Platform: samsung-laptop: add DMI information for Samsung N150 Plus
Date: Thu, 29 Dec 2011 12:45:52 +0100 [thread overview]
Message-ID: <4EFC52F0.1010709@t-online.de> (raw)
In-Reply-To: <4EFC3FA8.6020401@gmail.com>
Am 29.12.2011 11:23, schrieb Corentin Chary:
> On 12/26/2011 11:22 AM, David Herrmann wrote:
>> On Mon, Dec 26, 2011 at 10:49 AM, Corentin Chary
>> <corentin.chary@gmail.com> wrote:
>>> On Sat, Dec 24, 2011 at 3:28 PM, David Herrmann
>>> <dh.herrmann@googlemail.com> wrote:
>>>> On Sat, Dec 24, 2011 at 3:20 PM, Matthew
>>>> Garrett<mjg59@srcf.ucam.org> wrote:
>>>>> On Sat, Dec 24, 2011 at 02:12:57PM +0000, Andrzej Prochyra wrote:
>>>>>> 'acpi_video0' not functional. Brightness can be controlled through
>>>>>> intel_backlight interface. There are 21 brightness levels and the
>>>>>> backlight can be turned off.
>>>>>
>>>>> If acpi_video0 doesn't work then we either need to work out why
>>>>> it's not
>>>>> working or make it vanish completely, so this patch isn't the correct
>>>>> approach.
>>>>
>>>> Just to make clear, intel_backlight isn't working properly either. If
>>>> my laptop boots with backlight at 50% then intel_backlight will only
>>>> work in the range 0%-50% on my machine. If I use the samsung module to
>>>> set it to 100% then intel_backlight works correctly in the range
>>>> 0-100% until next reboot/suspend.
The same problem exists on my N145 Plus, too.
>>>> So I'd recommend staying with the samsung module and disabling the
>>>> acpi_backlight entirely. The samsung module is the only backlight
>>>> control which works properly.
>>>
>>> Can I take a look at the DSDT to see how it's broken ?
>>> If it's really not functional, then it should be added to the
>>> blacklist in video_detect.c
>>
>> Raw and disassembled dsdt is attached.
>
> Took a quick look but didn't find anything obvious. What happens exactly
> with acpi_video0 ?
Either Samsung's ACPI is totally broken [ACPI Warning: _BQC returned an
invalid level (20110623/video-472)] or they just don't support backlight
setting via ACPI at all. Therefore it's implemented in the SABI stuff.
So every device that needs SABI should be blacklisted in video_detect.
--
Regards,
Richard Schütz
next prev parent reply other threads:[~2011-12-29 11:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 22:19 [PATCH] Platform: samsung-laptop: add DMI information for Samsung N150 Plus Andrzej Prochyra
2011-12-23 14:15 ` Corentin Chary
2011-12-24 14:12 ` Andrzej Prochyra
2011-12-24 14:20 ` Matthew Garrett
2011-12-24 14:28 ` David Herrmann
2011-12-26 9:49 ` Corentin Chary
2011-12-26 10:22 ` David Herrmann
2011-12-29 10:23 ` Corentin Chary
2011-12-29 11:45 ` Richard Schütz [this message]
2011-12-29 11:49 ` Corentin Chary
2011-12-29 14:02 ` David Herrmann
2012-01-04 20:51 ` Seth Forshee
2012-01-05 7:18 ` Corentin Chary
2012-01-05 15:08 ` Seth Forshee
2012-01-07 14:12 ` [PATCH] ACPI / Video: blacklist some samsung laptops Corentin Chary
2012-01-08 10:46 ` Seth Forshee
2012-01-08 12:36 ` Corentin Chary
2012-01-08 12:36 ` Corentin Chary
2012-01-08 13:40 ` Seth Forshee
2012-01-09 16:39 ` David Herrmann
2012-01-09 22:34 ` Andrzej Prochyra
2011-12-26 9:51 ` [PATCH] Platform: samsung-laptop: add DMI information for Samsung N150 Plus Corentin Chary
2011-12-26 12:33 ` Matthew Garrett
2012-01-23 10:41 ` Corentin Chary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EFC52F0.1010709@t-online.de \
--to=r.schtz@t-online.de \
--cc=andrzej@prochyra.name \
--cc=corentin.chary@gmail.com \
--cc=dh.herrmann@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.