From mboxrd@z Thu Jan  1 00:00:00 1970
Message-ID: <4EFD73B2.7020801@freescale.com>
Date: Fri, 30 Dec 2011 16:17:54 +0800
From: Huang Shijie <b32955@freescale.com>
MIME-Version: 1.0
To: Baruch Siach <baruch@tkos.co.il>
Subject: Re: [PATCH] MTD/GPMI bugfix : reset the BCH module when it is not MX23
References: <1325215690-22209-1-git-send-email-b32955@freescale.com>
 <20111230074643.GA3018@tarshish>
In-Reply-To: <20111230074643.GA3018@tarshish>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: koen.beel.barco@gmail.com, w.sang@pengutronix.de, marek.vasut@gmail.com,
 linux-mtd@lists.infradead.org, Artem.Bityutskiy@intel.com, shijie8@gmail.com,
 linux-arm-kernel@lists.infradead.org, LW@KARO-electronics.de
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

Hi Baruch:
> Hi Huang,
>
> On Fri, Dec 30, 2011 at 11:28:10AM +0800, Huang Shijie wrote:
>> In MX28, if we do not reset the BCH module. The BCH module may
>> becomes unstable when the board reboots for several thousands times.
>> This bug has been catched in customer's production.
>>
>> The patch adds some comments, and fixes it now.
>>
>> Also change gpmi_reset_block() to static.
>>
>> Signed-off-by: Huang Shijie<b32955@freescale.com>
>> ---
> [snip]
>
>> -	ret = gpmi_reset_block(r->bch_regs, true);
>> +	/* The bug only exits in mx23, the following chips fix it. */
>> +	if (GPMI_IS_MX23(this))
>> +		ret = gpmi_reset_block(r->bch_regs, true);
>> +	else
>> +		ret = gpmi_reset_block(r->bch_regs, false);
> This can be shortened to:
>
>      ret = gpmi_reset_block(r->bch_regs, GPMI_IS_MX23(this));
thanks a lot.

I will use it in new patch.

Huang Shijie
>>   	if (ret)
>>   		goto err_out;
>>
>> -- 
>> 1.7.0.4
> baruch
>

From mboxrd@z Thu Jan  1 00:00:00 1970
From: b32955@freescale.com (Huang Shijie)
Date: Fri, 30 Dec 2011 16:17:54 +0800
Subject: [PATCH] MTD/GPMI bugfix : reset the BCH module when it is not MX23
In-Reply-To: <20111230074643.GA3018@tarshish>
References: <1325215690-22209-1-git-send-email-b32955@freescale.com>
 <20111230074643.GA3018@tarshish>
Message-ID: <4EFD73B2.7020801@freescale.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hi Baruch:
> Hi Huang,
>
> On Fri, Dec 30, 2011 at 11:28:10AM +0800, Huang Shijie wrote:
>> In MX28, if we do not reset the BCH module. The BCH module may
>> becomes unstable when the board reboots for several thousands times.
>> This bug has been catched in customer's production.
>>
>> The patch adds some comments, and fixes it now.
>>
>> Also change gpmi_reset_block() to static.
>>
>> Signed-off-by: Huang Shijie<b32955@freescale.com>
>> ---
> [snip]
>
>> -	ret = gpmi_reset_block(r->bch_regs, true);
>> +	/* The bug only exits in mx23, the following chips fix it. */
>> +	if (GPMI_IS_MX23(this))
>> +		ret = gpmi_reset_block(r->bch_regs, true);
>> +	else
>> +		ret = gpmi_reset_block(r->bch_regs, false);
> This can be shortened to:
>
>      ret = gpmi_reset_block(r->bch_regs, GPMI_IS_MX23(this));
thanks a lot.

I will use it in new patch.

Huang Shijie
>>   	if (ret)
>>   		goto err_out;
>>
>> -- 
>> 1.7.0.4
> baruch
>