From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>,
afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH 4/4] target-mips: Fix MIPS_DEBUG.
Date: Sun, 01 Jan 2012 09:23:29 +1100 [thread overview]
Message-ID: <4EFF8B61.7020908@twiddle.net> (raw)
In-Reply-To: <CAFEAcA_HDVrC_Auu0+LBdCOddL8=JiUrZFcnw3ASg7A2_MNTcg@mail.gmail.com>
On 12/31/2011 10:50 PM, Peter Maydell wrote:
>> +static void gen_logic_imm (CPUState *env, DisasContext *ctx, uint32_t opc,
>> + int rt, int rs, int16_t imm)
>> {
>> target_ulong uimm;
>> const char *opn = "imm logic";
>
> Am I missing something, or does gen_logic_imm() not actually use env at all?
> Maybe we should be replacing env with ctx in the parameter list in some/most
> of these functions rather than adding it?
You're not missing anything.
Really, env should not be used by anything in that file except for the
outermost gen_intermediate_code_internal, which already copies the bits
that are needed to the ctx.
Cleaning up incorrect uses of env throughout that file is a larger job.
r~
next prev parent reply other threads:[~2011-12-31 22:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-31 4:54 [Qemu-devel] [PATCH 1/4] target-mips: Pass DisasContext to fpr32 load/store routines Richard Henderson
2011-12-31 4:54 ` [Qemu-devel] [PATCH 2/4] target-mips: Use TCG registers for the FPU Richard Henderson
2011-12-31 4:54 ` [Qemu-devel] [PATCH 3/4] target-mips: Add accessors for the two 32-bit halves of a 64-bit FPR Richard Henderson
2011-12-31 4:54 ` [Qemu-devel] [PATCH 4/4] target-mips: Fix MIPS_DEBUG Richard Henderson
2011-12-31 11:50 ` Peter Maydell
2011-12-31 22:23 ` Richard Henderson [this message]
2011-12-31 12:03 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EFF8B61.7020908@twiddle.net \
--to=rth@twiddle.net \
--cc=afaerber@suse.de \
--cc=aurelien@aurel32.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.