From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>, <ath6kl-devel@qualcomm.com>
Subject: Re: [PATCH 3/3] ath6kl: Remove few deadcode in main.c
Date: Mon, 2 Jan 2012 18:33:15 +0200 [thread overview]
Message-ID: <4F01DC4B.50501@qca.qualcomm.com> (raw)
In-Reply-To: <1325154939-6986-3-git-send-email-vthiagar@qca.qualcomm.com>
On 12/29/2011 12:35 PM, Vasanthakumar Thiagarajan wrote:
> 1. In ath6kl_add_new_sta(), if (ielen <= ATH6KL_MAX_IE) is going to be
> always true due to ielen being u8 and is checked against 256.
>
> 2. In ath6kl_reset_device(), since control can never reach switch..case
> when the target_type is neither TARGET_TYPE_AR6003 nor TARGET_TYPE_AR6004,
> remove the default option of switch statement.
Two separate patches, please.
> @@ -62,8 +62,7 @@ static void ath6kl_add_new_sta(struct ath6kl *ar, u8 *mac, u16 aid, u8 *wpaie,
>
> sta = &ar->sta_list[free_slot];
> memcpy(sta->mac, mac, ETH_ALEN);
> - if (ielen <= ATH6KL_MAX_IE)
> - memcpy(sta->wpa_ie, wpaie, ielen);
> + memcpy(sta->wpa_ie, wpaie, ielen);
And then someone changes the u8 ielen to something else and accidentally
adds a bug. I would prefer to have an explicit check for the ielen to
make it obvious what's the maximum length.
I don't really like using u8 for ielen either. IMHO size_t or similar
would be better.
Kalle
next prev parent reply other threads:[~2012-01-02 17:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-29 10:35 [PATCH 1/3] ath6kl: Remove few unnecessary spin_locks around set_bit() Vasanthakumar Thiagarajan
2011-12-29 10:35 ` [PATCH 2/3] ath6kl: Add a module parameter to enable uart debug Vasanthakumar Thiagarajan
2011-12-29 10:35 ` [PATCH 3/3] ath6kl: Remove few deadcode in main.c Vasanthakumar Thiagarajan
2012-01-02 16:33 ` Kalle Valo [this message]
2012-01-03 5:40 ` Vasanthakumar Thiagarajan
2012-01-03 8:12 ` Johannes Berg
2012-01-03 9:35 ` Vasanthakumar Thiagarajan
2012-01-02 16:35 ` [PATCH 1/3] ath6kl: Remove few unnecessary spin_locks around set_bit() Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F01DC4B.50501@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=vthiagar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.