From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:51063)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Rhm28-00010g-G0
	for qemu-devel@nongnu.org; Mon, 02 Jan 2012 12:50:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Rhm27-00081u-Hn
	for qemu-devel@nongnu.org; Mon, 02 Jan 2012 12:50:52 -0500
Received: from cantor2.suse.de ([195.135.220.15]:54870 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Rhm27-00081g-D4
	for qemu-devel@nongnu.org; Mon, 02 Jan 2012 12:50:51 -0500
Message-ID: <4F01EE24.3050606@suse.de>
Date: Mon, 02 Jan 2012 18:49:24 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1325438591-7355-1-git-send-email-avi@redhat.com>
In-Reply-To: <1325438591-7355-1-git-send-email-avi@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] Fix wrong region_offset when overlaying a
 page with another
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org

Am 01.01.2012 18:23, schrieb Avi Kivity:
> cpu_register_physical_memory_log() does not update region_offset
> if a page was previously registered for the same address.  This
> could cause mmio accesses going to the wrong place, by using the
> old region_offset.
>=20
> Signed-off-by: Avi Kivity <avi@redhat.com>

Line numbers don't match master ;) but applies cleanly and looks good.

Acked-by: Andreas F=E4rber <afaerber@suse.de>

Andreas

>  exec.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>=20
> diff --git a/exec.c b/exec.c
> index 8a3f621..c366835 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -2542,6 +2542,7 @@ void cpu_register_physical_memory_log(target_phys=
_addr_t start_addr,
>                  p->region_offset =3D 0;
>              } else {
>                  p->phys_offset =3D phys_offset;
> +                p->region_offset =3D region_offset;
>                  if ((phys_offset & ~TARGET_PAGE_MASK) <=3D IO_MEM_ROM =
||
>                      (phys_offset & IO_MEM_ROMD))
>                      phys_offset +=3D TARGET_PAGE_SIZE;

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg