From: Hans de Goede <hdegoede@redhat.com>
To: Vasily Khoruzhick <anarsoul@gmail.com>
Cc: Hans de Goede <j.w.r.degoede@hhs.nl>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] libv4l: add hflip quirk for dealextreme cam sku #44507
Date: Tue, 03 Jan 2012 09:39:33 +0100 [thread overview]
Message-ID: <4F02BEC5.2080204@redhat.com> (raw)
In-Reply-To: <1325535901-15251-1-git-send-email-anarsoul@gmail.com>
Hi,
Thanks for the patch.
I'm sorry, but a quick google shows that your cam has a usb id used by various generic
cameras, including some microscopes, see:
http://blog.littleimpact.de/index.php/2011/10/16/using-biolux-nv-on-ubuntu-linux/
Enabling flipping on all these models because one has the sensor mounted upside down
is the wrong thing to do.
Instead you could add the following to your /etc/profile
export LIBV4LCONTROL_FLAGS=3
Note this will flip the image from all cameras you plug into your computer, or you
can keep a patched libv4l around for yourself.
Regards,
Hans
On 01/02/2012 09:25 PM, Vasily Khoruzhick wrote:
> Signed-off-by: Vasily Khoruzhick<anarsoul@gmail.com>
> ---
> lib/libv4lconvert/control/libv4lcontrol.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/lib/libv4lconvert/control/libv4lcontrol.c b/lib/libv4lconvert/control/libv4lcontrol.c
> index 12fa874..a9908ac 100644
> --- a/lib/libv4lconvert/control/libv4lcontrol.c
> +++ b/lib/libv4lconvert/control/libv4lcontrol.c
> @@ -51,6 +51,8 @@ static const struct v4lcontrol_flags_info v4lcontrol_flags[] = {
> /* Genius E-M 112 (also want whitebalance by default) */
> { 0x093a, 0x2476, 0, NULL, NULL,
> V4LCONTROL_HFLIPPED|V4LCONTROL_VFLIPPED | V4LCONTROL_WANTS_WB, 1500 },
> + /* uvc-compatible cam from dealextreme (sku #44507) */
> + { 0x18ec, 0x3366, 0, NULL, NULL, V4LCONTROL_HFLIPPED },
>
> /* Laptops (and all in one PC's) */
> { 0x0402, 0x5606, 0,
next prev parent reply other threads:[~2012-01-03 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-02 20:25 [PATCH] libv4l: add hflip quirk for dealextreme cam sku #44507 Vasily Khoruzhick
2012-01-03 8:39 ` Hans de Goede [this message]
2012-01-03 12:25 ` Vasily
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F02BEC5.2080204@redhat.com \
--to=hdegoede@redhat.com \
--cc=anarsoul@gmail.com \
--cc=j.w.r.degoede@hhs.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.