From: Duss Pirmin <pirmin.duss@flytec.ch>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [Patch v2.1] Adds support for the Texas Instruments ADS1110 adc.
Date: Tue, 03 Jan 2012 10:37:25 +0100 [thread overview]
Message-ID: <4F02CC55.9080206@flytec.ch> (raw)
In-Reply-To: <4EFF699B.1000802@kernel.org>
>> +
>> + /* read the config register from the chip */
>> + ret = ads1110_i2c_read_config(chip,&chip->config);
>> + if (ret != 3)
>> + goto error_free_dev;
> Any chance this could be ret == 2? If so you are returning a non
> error in a case where there has been one... Odd case, but might as
> well get it right.
ads1110_i2c_read_config returns number of bytes read or a negative error
value. If we could not read three bytes there was an error.
prev parent reply other threads:[~2012-01-03 9:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 11:17 [PATCH v2] Adds support for the Texas Instruments ADS1110 adc Pirmin Duss
2011-12-21 11:46 ` Lars-Peter Clausen
2011-12-22 10:18 ` [PATCH v2.1] " Pirmin Duss
2011-12-23 8:09 ` J.I. Cameron
2011-12-23 9:02 ` [Patch " Pirmin Duss
2011-12-31 19:59 ` Jonathan Cameron
2012-01-01 10:53 ` Lars-Peter Clausen
2012-01-03 9:37 ` Duss Pirmin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F02CC55.9080206@flytec.ch \
--to=pirmin.duss@flytec.ch \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.