From: Lars-Peter Clausen <lars@metafoo.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, pirmin.duss@flytec.ch
Subject: Re: [PATCH 2/6] staging:iio:dds:ad9834 unwind use of is_visible for attrs.
Date: Tue, 03 Jan 2012 10:45:59 +0100 [thread overview]
Message-ID: <4F02CE57.9040202@metafoo.de> (raw)
In-Reply-To: <1325525123-31158-3-git-send-email-jic23@kernel.org>
On 01/02/2012 06:25 PM, Jonathan Cameron wrote:
> Trivial usecase in which just having two different attr
> groups covers all options. Slightly more code, but a simpler
> to follow result.
>
> static int __devinit ad9834_probe(struct spi_device *spi)
> {
> struct ad9834_platform_data *pdata = spi->dev.platform_data;
> @@ -344,7 +347,10 @@ static int __devinit ad9834_probe(struct spi_device *spi)
> st->reg = reg;
> indio_dev->dev.parent = &spi->dev;
> indio_dev->name = spi_get_device_id(spi)->name;
> - indio_dev->info = &ad9834_info;
> + if ((st->devid == ID_AD9833) || (st->devid == ID_AD9837))
Maybe use a switch statement.
> + indio_dev->info = &ad9833_info;
> + else
> + indio_dev->info = &ad9834_info;
> indio_dev->modes = INDIO_DIRECT_MODE;
>
> /* Setup default messages */
next prev parent reply other threads:[~2012-01-03 9:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-02 17:25 [RFC PATCH 0/6] Make iio_info elements attrs and event_attrs struct attribute * Jonathan Cameron
2012-01-02 17:25 ` [PATCH 1/6] staging:iio:adc:ad7192 unwind use of is_visible for attribute group Jonathan Cameron
2012-01-02 17:25 ` [PATCH 4/6] staging:iio:adc:ad7606 unwind use of is_visible for attrs Jonathan Cameron
2012-01-02 17:25 ` [PATCH 5/6] staging:iio:adc:adt7310/7410 sticking plaster fix for broken event attrs Jonathan Cameron
2012-01-02 17:25 ` [PATCH 6/6] staging:iio:treewide make attrs and event_attrs entries struct attribute * Jonathan Cameron
2012-01-03 9:44 ` [RFC PATCH 0/6] Make iio_info elements attrs and event_attrs " Lars-Peter Clausen
2012-01-03 17:24 ` Jonathan Cameron
[not found] ` <1325525123-31158-3-git-send-email-jic23@kernel.org>
2012-01-03 9:45 ` Lars-Peter Clausen [this message]
2012-01-03 17:12 ` [PATCH 2/6] staging:iio:dds:ad9834 unwind use of is_visible for attrs Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2012-01-07 10:25 [PATCH V2 0/6] attrs and event_attrs out of iio_info and without wrapping group Jonathan Cameron
2012-01-07 10:25 ` [PATCH 2/6] staging:iio:dds:ad9834 unwind use of is_visible for attrs Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F02CE57.9040202@metafoo.de \
--to=lars@metafoo.de \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=pirmin.duss@flytec.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.