From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Garrett Cooper <yanegomi@gmail.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH 02/21] lib/self_exec: Remove extra argument from tst_resm function call
Date: Tue, 3 Jan 2012 09:57:54 +0000 [thread overview]
Message-ID: <4F02D122.7090704@imgtec.com> (raw)
In-Reply-To: <CAGH67wSFbMM+3Dr_pe=_+w_B4Su6p6wZ42LpP5vUwVE1hiH6QQ@mail.gmail.com>
On 01/03/2012 09:50 AM, Garrett Cooper wrote:
> On Tue, Jan 3, 2012 at 1:35 AM, Markos Chandras
> <Markos.Chandras@imgtec.com> wrote:
>> Hi, please review the attached patch
>
> Converting the function to tst_brkm and removing the tst_exit call
> below it would be better.
> Thanks!
> -Garrett
Agreed, but to make this consistent, all the tst_resm && tst_exit pairs
should be replaced with tst_brkm. I will prepare a patch
--
markos
------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create
new or port existing apps to sell to consumers worldwide. Explore the
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2012-01-03 9:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-03 9:35 [LTP] [PATCH 02/21] lib/self_exec: Remove extra argument from tst_resm function call Markos Chandras
2012-01-03 9:50 ` Garrett Cooper
2012-01-03 9:57 ` Markos Chandras [this message]
2012-01-03 10:40 ` Markos Chandras
2012-01-03 18:01 ` Garrett Cooper
2012-01-04 14:20 ` Cyril Hrubis
[not found] ` <4F045E94.3060004@imgtec.com>
2012-01-04 15:35 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F02D122.7090704@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=yanegomi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.