From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Remove BUILD_BUG_ON from asm/bug.h
Date: Tue, 03 Jan 2012 14:33:01 -0800 [thread overview]
Message-ID: <4F03821D.9080503@codeaurora.org> (raw)
In-Reply-To: <1325616276-10304-1-git-send-email-sjg@chromium.org>
On 01/03/12 10:44, Simon Glass wrote:
> BUILD_BUG_ON is defined in linux/kernel.h but that is not included by the
> asm/bug.h header which uses it. This causes a build error:
>
> ...include/linux/mtd/map.h: In function 'inline_map_read':
> ...include/linux/mtd/map.h:408:3: error: implicit declaration of function
> 'BUILD_BUG_ON' [-Werror=implicit-function-declaration]
>
> The check is not essential and is not present for other architectures, so
> just remove it.
I thought this check was put in place to catch changes to struct
bug_entry being out of sync with the __BUG macro defined in ARM. Why
can't we include kernel.h instead? Or can you elaborate some more on why
we don't need this check in the commit text?
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Simon Glass <sjg@chromium.org>
Cc: linux-arm-kernel@lists.infradead.org,
Ben Hutchings <ben@decadent.org.uk>,
Olof Johansson <olofj@chromium.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
LKML <linux-kernel@vger.kernel.org>,
Dave Martin <dave.martin@linaro.org>
Subject: Re: [PATCH] ARM: Remove BUILD_BUG_ON from asm/bug.h
Date: Tue, 03 Jan 2012 14:33:01 -0800 [thread overview]
Message-ID: <4F03821D.9080503@codeaurora.org> (raw)
In-Reply-To: <1325616276-10304-1-git-send-email-sjg@chromium.org>
On 01/03/12 10:44, Simon Glass wrote:
> BUILD_BUG_ON is defined in linux/kernel.h but that is not included by the
> asm/bug.h header which uses it. This causes a build error:
>
> ...include/linux/mtd/map.h: In function 'inline_map_read':
> ...include/linux/mtd/map.h:408:3: error: implicit declaration of function
> 'BUILD_BUG_ON' [-Werror=implicit-function-declaration]
>
> The check is not essential and is not present for other architectures, so
> just remove it.
I thought this check was put in place to catch changes to struct
bug_entry being out of sync with the __BUG macro defined in ARM. Why
can't we include kernel.h instead? Or can you elaborate some more on why
we don't need this check in the commit text?
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2012-01-03 22:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-03 18:44 [PATCH] ARM: Remove BUILD_BUG_ON from asm/bug.h Simon Glass
2012-01-03 18:44 ` Simon Glass
2012-01-03 19:39 ` Olof Johansson
2012-01-03 19:39 ` Olof Johansson
2012-01-03 19:50 ` Simon Glass
2012-01-03 19:50 ` Simon Glass
2012-01-03 22:33 ` Stephen Boyd [this message]
2012-01-03 22:33 ` Stephen Boyd
2012-01-03 22:40 ` Simon Glass
2012-01-03 22:40 ` Simon Glass
2012-01-03 23:26 ` Stephen Boyd
2012-01-03 23:26 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F03821D.9080503@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.