All of lore.kernel.org
 help / color / mirror / Atom feed
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Remove BUILD_BUG_ON from asm/bug.h
Date: Tue, 03 Jan 2012 15:26:55 -0800	[thread overview]
Message-ID: <4F038EBF.5030408@codeaurora.org> (raw)
In-Reply-To: <CAPnjgZ1P6bdAGRa-9ZyuNMT7jRAfrH3abWJPkxVeeM7BDKsXTg@mail.gmail.com>

On 01/03/12 14:40, Simon Glass wrote:
> Yes that is the reason, but ARM is not unique in this matter, and
> other archs do not have this check. I did suggest a solution in this
> thread involving putting the check in a C file instead of header. But
> it needs an arch-specific #define to specify the size expected by the
> assembler, and has the disadvantage of moving the check away from the
> assembler code.
>
> It's not that we don't want this check, more that it is not essential
> (since there is currently no mismatch), it is causing problems and it
> is risky to try to solve this problem some other way at this late
> stage in 3.2. So the easiest thing is to remove it, to match other
> archs.

Fair enough. I now see the other thread where this has all been
discussed. Sorry for the noise.

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Simon Glass <sjg@chromium.org>
Cc: linux-arm-kernel@lists.infradead.org,
	Ben Hutchings <ben@decadent.org.uk>,
	Olof Johansson <olofj@chromium.org>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	LKML <linux-kernel@vger.kernel.org>,
	Dave Martin <dave.martin@linaro.org>
Subject: Re: [PATCH] ARM: Remove BUILD_BUG_ON from asm/bug.h
Date: Tue, 03 Jan 2012 15:26:55 -0800	[thread overview]
Message-ID: <4F038EBF.5030408@codeaurora.org> (raw)
In-Reply-To: <CAPnjgZ1P6bdAGRa-9ZyuNMT7jRAfrH3abWJPkxVeeM7BDKsXTg@mail.gmail.com>

On 01/03/12 14:40, Simon Glass wrote:
> Yes that is the reason, but ARM is not unique in this matter, and
> other archs do not have this check. I did suggest a solution in this
> thread involving putting the check in a C file instead of header. But
> it needs an arch-specific #define to specify the size expected by the
> assembler, and has the disadvantage of moving the check away from the
> assembler code.
>
> It's not that we don't want this check, more that it is not essential
> (since there is currently no mismatch), it is causing problems and it
> is risky to try to solve this problem some other way at this late
> stage in 3.2. So the easiest thing is to remove it, to match other
> archs.

Fair enough. I now see the other thread where this has all been
discussed. Sorry for the noise.

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.


  reply	other threads:[~2012-01-03 23:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-03 18:44 [PATCH] ARM: Remove BUILD_BUG_ON from asm/bug.h Simon Glass
2012-01-03 18:44 ` Simon Glass
2012-01-03 19:39 ` Olof Johansson
2012-01-03 19:39   ` Olof Johansson
2012-01-03 19:50   ` Simon Glass
2012-01-03 19:50     ` Simon Glass
2012-01-03 22:33 ` Stephen Boyd
2012-01-03 22:33   ` Stephen Boyd
2012-01-03 22:40   ` Simon Glass
2012-01-03 22:40     ` Simon Glass
2012-01-03 23:26     ` Stephen Boyd [this message]
2012-01-03 23:26       ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F038EBF.5030408@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.