From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Heiny Subject: Re: [RFC PATCH 00/11] input: Synaptics RMI4 Touchscreen Driver Date: Tue, 3 Jan 2012 17:51:01 -0800 Message-ID: <4F03B085.6000101@synaptics.com> References: <1324519802-23894-1-git-send-email-cheiny@synaptics.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij Cc: Dmitry Torokhov , Jean Delvare , Linux Kernel , Linux Input , Joerie de Gram , Linus Walleij , Naveen Kumar Gaddipati List-Id: linux-input@vger.kernel.org On 01/01/2012 05:51 AM, Linus Walleij wrote: > On Thu, Dec 22, 2011 at 3:09 AM, Christopher Heiny wrote: > >> This patch implements a driver supporting Synaptics ClearPad and other >> touchscreen sensors that use the RMI4 protocol, as defined here: > > This looks like a fundamental rewrite an huge improvement over the > previous RMI4 patches, good job! > > I am not very deeply versed in the input subsystem but overall it looks > good to me, nice structure etc. I hope to be able to get back to a detailed > review and per-patch Acked-by:s ASAP. Thanks! We realized we were in a red queen's race by trying to both implement customer requests and restructure the system at the same time, so contracted Unixphere to help with the restructure. We think the result was pretty good, and it's nice to hear compliments. We'll look forward to your input after the detailed review. Thanks again, Chris