From: Graeme Russ <graeme.russ@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 11/17] CHECKPATCH: arch/x86/cpu/*
Date: Wed, 04 Jan 2012 22:35:04 +1100 [thread overview]
Message-ID: <4F043968.8050301@gmail.com> (raw)
In-Reply-To: <CAPnjgZ30Mj34zfQG19QSvvBOtXz71V7x6OX=zKf40_y7S0sHVQ@mail.gmail.com>
Hi Simon,
On 04/01/12 16:42, Simon Glass wrote:
> Hi Graeme,
>
> On Sun, Jan 1, 2012 at 8:09 PM, Graeme Russ <graeme.russ@gmail.com> wrote:
>>
>> Signed-off-by: Graeme Russ <graeme.russ@gmail.com>
>
> Seems a bit more than just checkpatch.
True - I'll change the name to 'Tweak IDT and GDT for alignment and
readability' - Saves me splitting the patch ;)
Regards,
Graeme
>
> Acked-by: Simon Glass <sjg@chromium.org>
>
> Regards,
> Simon
>
>> ---
>> arch/x86/cpu/interrupts.c | 2 +-
>> arch/x86/cpu/start16.S | 57 +++++++++++++++++++++++++++++++++++---------
>> 2 files changed, 46 insertions(+), 13 deletions(-)
>>
>> diff --git a/arch/x86/cpu/interrupts.c b/arch/x86/cpu/interrupts.c
>> index e0958eb..43ec3f8 100644
>> --- a/arch/x86/cpu/interrupts.c
>> +++ b/arch/x86/cpu/interrupts.c
>> @@ -174,7 +174,7 @@ struct desc_ptr {
>> unsigned short segment;
>> } __packed;
>>
>> -struct idt_entry idt[256] __attribute__((aligned(16)));
>> +struct idt_entry idt[256] __aligned(16);
>>
>> struct desc_ptr idt_ptr;
>>
>> diff --git a/arch/x86/cpu/start16.S b/arch/x86/cpu/start16.S
>> index 33e53cd..cc393ff 100644
>> --- a/arch/x86/cpu/start16.S
>> +++ b/arch/x86/cpu/start16.S
>> @@ -86,7 +86,11 @@ gdt_ptr:
>> .word 0x20 /* limit (32 bytes = 4 GDT entries) */
>> .long BOOT_SEG + gdt /* base */
>>
>> - /* The GDT table ...
>> +/* Some CPUs are picky about GDT alignment... */
>> +.align 16
>> +gdt:
>> + /*
>> + * The GDT table ...
>> *
>> * Selector Type
>> * 0x00 NULL
>> @@ -94,17 +98,46 @@ gdt_ptr:
>> * 0x10 32bit code
>> * 0x18 32bit data/stack
>> */
>> + /* The NULL Desciptor - Mandatory */
>> + .word 0x0000 /* limit_low */
>> + .word 0x0000 /* base_low */
>> + .byte 0x00 /* base_middle */
>> + .byte 0x00 /* access */
>> + .byte 0x00 /* flags + limit_high */
>> + .byte 0x00 /* base_high */
>>
>> -gdt:
>> - .word 0, 0, 0, 0 /* NULL */
>> - .word 0, 0, 0, 0 /* unused */
>> + /* Unused Desciptor - (matches Linux) */
>> + .word 0x0000 /* limit_low */
>> + .word 0x0000 /* base_low */
>> + .byte 0x00 /* base_middle */
>> + .byte 0x00 /* access */
>> + .byte 0x00 /* flags + limit_high */
>> + .byte 0x00 /* base_high */
>>
>> - .word 0xFFFF /* 4Gb - (0x100000*0x1000 = 4Gb) */
>> - .word 0 /* base address = 0 */
>> - .word 0x9B00 /* code read/exec */
>> - .word 0x00CF /* granularity = 4096, 386 (+5th nibble of limit) */
>> + /*
>> + * The Code Segment Descriptor:
>> + * - Base = 0x00000000
>> + * - Size = 4GB
>> + * - Access = Present, Ring 0, Exec (Code), Readable
>> + * - Flags = 4kB Granularity, 32-bit
>> + */
>> + .word 0xffff /* limit_low */
>> + .word 0x0000 /* base_low */
>> + .byte 0x00 /* base_middle */
>> + .byte 0x9b /* access */
>> + .byte 0xcf /* flags + limit_high */
>> + .byte 0x00 /* base_high */
>>
>> - .word 0xFFFF /* 4Gb - (0x100000*0x1000 = 4Gb) */
>> - .word 0x0 /* base address = 0 */
>> - .word 0x9300 /* data read/write */
>> - .word 0x00CF /* granularity = 4096, 386 (+5th nibble of limit) */
>> + /*
>> + * The Data Segment Descriptor:
>> + * - Base = 0x00000000
>> + * - Size = 4GB
>> + * - Access = Present, Ring 0, Non-Exec (Data), Writable
>> + * - Flags = 4kB Granularity, 32-bit
>> + */
>> + .word 0xffff /* limit_low */
>> + .word 0x0000 /* base_low */
>> + .byte 0x00 /* base_middle */
>> + .byte 0x93 /* access */
>> + .byte 0xcf /* flags + limit_high */
>> + .byte 0x00 /* base_high */
>> --
>> 1.7.5.2.317.g391b14
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>
next prev parent reply other threads:[~2012-01-04 11:35 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-02 4:09 [U-Boot] [PATCH 00/17] x86: Rework of board init code (plus support patches) Graeme Russ
2012-01-02 4:09 ` [U-Boot] [PATCH 01/17] x86: Import glibc memcpy implementation Graeme Russ
2012-01-04 5:18 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 " Graeme Russ
2012-01-04 19:59 ` [U-Boot] [PATCH v2 02/17] x86: Speed up copy-to-RAM and clear BSS operations Graeme Russ
2012-01-04 20:04 ` Graeme Russ
2012-01-12 4:45 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 03/17] x86: Remove GDR related magic numbers Graeme Russ
2012-01-07 22:05 ` Simon Glass
2012-01-12 4:46 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 04/17] x86: Rework Global Descriptor Table loading Graeme Russ
2012-01-12 4:47 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 05/17] x86: Simplify Flash-to-RAM code execution transition Graeme Russ
2012-01-12 4:48 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 06/17] x86: Rework relocation calculations Graeme Russ
2012-01-12 4:49 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 07/17] x86: Use fs for global data Graeme Russ
2012-01-12 4:51 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 08/17] x86: Set GD_FLG_RELOC after entering in-RAM copy of U-Boot Graeme Russ
2012-01-12 4:51 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 09/17] x86: Create weak init_cache() and default enable_caches() functions Graeme Russ
2012-01-12 4:55 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 10/17] x86: Allow cache before copy to RAM Graeme Russ
2012-01-12 4:56 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 11/17] x86: Tweak IDT and GDT for alignment and readability Graeme Russ
2012-01-12 5:00 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 12/17] CHECKPATCH: arch/x86/lib/* Graeme Russ
2012-01-12 5:01 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 13/17] x86: Move do_go_exec() out of board.c Graeme Russ
2012-01-12 5:01 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 14/17] x86: Move setup_pcat_compatibility() " Graeme Russ
2012-01-12 5:02 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 15/17] x86: Move relocation code " Graeme Russ
2012-01-07 22:15 ` Simon Glass
2012-01-08 9:04 ` Graeme Russ
2012-01-08 17:59 ` Simon Glass
2012-01-12 5:03 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 16/17] x86: Split init functions " Graeme Russ
2012-01-12 5:03 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 17/17] x86: Convert board_init_f_r to a processing loop Graeme Russ
2012-01-07 22:21 ` Simon Glass
2012-01-08 9:10 ` Graeme Russ
2012-01-08 18:01 ` Simon Glass
2012-01-12 5:04 ` Simon Glass
2012-01-12 4:44 ` [U-Boot] [PATCH v2 01/17] x86: Import glibc memcpy implementation Simon Glass
2012-01-02 4:09 ` [U-Boot] [PATCH 02/17] x86: Speed up copy-to-RAM and clear BSS operations Graeme Russ
2012-01-04 5:21 ` Simon Glass
2012-01-04 10:04 ` Graeme Russ
2012-01-02 4:09 ` [U-Boot] [PATCH 03/17] x86: Remove GDR related magic numbers Graeme Russ
2012-01-04 5:23 ` Simon Glass
2012-01-04 10:20 ` Graeme Russ
2012-01-02 4:09 ` [U-Boot] [PATCH 04/17] x86: Rework Global Descriptor Table loading Graeme Russ
2012-01-04 5:24 ` Simon Glass
2012-01-04 10:30 ` Graeme Russ
2012-01-02 4:09 ` [U-Boot] [PATCH 05/17] x86: Simplify Flash-to-RAM code execution transition Graeme Russ
2012-01-04 5:28 ` Simon Glass
2012-01-04 10:59 ` Graeme Russ
2012-01-02 4:09 ` [U-Boot] [PATCH 06/17] x86: Rework relocation calcuations Graeme Russ
2012-01-04 5:30 ` Simon Glass
2012-01-02 4:09 ` [U-Boot] [PATCH 07/17] x86: Use fs for global data Graeme Russ
2012-01-04 5:36 ` Simon Glass
2012-01-04 11:14 ` Graeme Russ
2012-01-02 4:09 ` [U-Boot] [PATCH 08/17] x86: Set GD_FLG_RELOC after entering in-RAM copy of U-Boot Graeme Russ
2012-01-04 5:37 ` Simon Glass
2012-01-02 4:09 ` [U-Boot] [PATCH 09/17] x86: Create weak init_cache() function Graeme Russ
2012-01-04 5:38 ` Simon Glass
2012-01-04 11:25 ` Graeme Russ
2012-01-02 4:09 ` [U-Boot] [PATCH 10/17] x86: Allow cache before copy to RAM Graeme Russ
2012-01-04 5:40 ` Simon Glass
2012-01-04 11:29 ` Graeme Russ
2012-01-02 4:09 ` [U-Boot] [PATCH 11/17] CHECKPATCH: arch/x86/cpu/* Graeme Russ
2012-01-04 5:42 ` Simon Glass
2012-01-04 11:35 ` Graeme Russ [this message]
2012-01-02 4:09 ` [U-Boot] [PATCH 12/17] CHECKPATCH: arch/x86/lib/* Graeme Russ
2012-01-04 5:47 ` Simon Glass
2012-01-02 4:09 ` [U-Boot] [PATCH 13/17] x86: Move do_go_exec() out of board.c Graeme Russ
2012-01-04 5:48 ` Simon Glass
2012-01-02 4:09 ` [U-Boot] [PATCH 14/17] x86: Move setup_pcat_compatibility() " Graeme Russ
2012-01-04 5:48 ` Simon Glass
2012-01-04 11:38 ` Graeme Russ
2012-01-02 4:09 ` [U-Boot] [PATCH 15/17] x86: Move relocation code " Graeme Russ
2012-01-02 4:09 ` [U-Boot] [PATCH 16/17] x86: Simplify board.c Graeme Russ
2012-01-04 5:51 ` Simon Glass
2012-01-04 11:50 ` Graeme Russ
2012-01-02 4:09 ` [U-Boot] [PATCH 17/17] x86: Tweak initialisation procedure Graeme Russ
2012-01-04 5:52 ` Simon Glass
2012-01-04 12:02 ` Graeme Russ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F043968.8050301@gmail.com \
--to=graeme.russ@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.