From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Wed, 04 Jan 2012 12:11:49 +0000 Subject: Re: [PATCH 1/2] KVM: PPC: epapr: Add idle hcall support for host Message-Id: <4F044205.7040801@redhat.com> List-Id: References: <1325312176-17697-1-git-send-email-yu.liu@freescale.com> <4F030A51.3020309@redhat.com> <4F042B11.1080104@redhat.com> <1F66722B-9268-4E3D-874A-1F24BC341F79@suse.de> In-Reply-To: <1F66722B-9268-4E3D-874A-1F24BC341F79@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf Cc: Liu Yu , "kvm-ppc@vger.kernel.org" , "kvm@vger.kernel.org" On 01/04/2012 02:04 PM, Alexander Graf wrote: > >> Not if we put the bit into flags. Then user space can just check the flags bitmap and know that it's there regardless of capabilities, because older kernels will set the bit to 0. > > > > It needs to detect that opt_features is available during compile time > > (qemu copies headers, but we don't want to force everyone to do that). > > The point is that we don't need opt_features. We already have a fearure bitmap in the struct. Ah! Okay then. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/2] KVM: PPC: epapr: Add idle hcall support for host Date: Wed, 04 Jan 2012 14:11:49 +0200 Message-ID: <4F044205.7040801@redhat.com> References: <1325312176-17697-1-git-send-email-yu.liu@freescale.com> <4F030A51.3020309@redhat.com> <4F042B11.1080104@redhat.com> <1F66722B-9268-4E3D-874A-1F24BC341F79@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Liu Yu , "kvm-ppc@vger.kernel.org" , "kvm@vger.kernel.org" To: Alexander Graf Return-path: In-Reply-To: <1F66722B-9268-4E3D-874A-1F24BC341F79@suse.de> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 01/04/2012 02:04 PM, Alexander Graf wrote: > >> Not if we put the bit into flags. Then user space can just check the flags bitmap and know that it's there regardless of capabilities, because older kernels will set the bit to 0. > > > > It needs to detect that opt_features is available during compile time > > (qemu copies headers, but we don't want to force everyone to do that). > > The point is that we don't need opt_features. We already have a fearure bitmap in the struct. Ah! Okay then. -- error compiling committee.c: too many arguments to function