From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from va3ehsobe006.messaging.microsoft.com ([216.32.180.16] helo=VA3EHSOBE009.bigfish.com) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1RiUfD-0004tS-BF for linux-mtd@lists.infradead.org; Wed, 04 Jan 2012 17:30:11 +0000 Message-ID: <4F048C99.2010302@freescale.com> Date: Wed, 4 Jan 2012 11:30:01 -0600 From: Scott Wood MIME-Version: 1.0 To: Huang Shijie Subject: Re: GPMI-NAND: Wrong ECC size in driver References: <201201040148.32847.marek.vasut@gmail.com> <4F03EA83.9030503@freescale.com> In-Reply-To: <4F03EA83.9030503@freescale.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Marek Vasut , linux-mtd@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 01/03/2012 11:58 PM, Huang Shijie wrote: > Hi Marek: >> Hi, >> >> the gpmi-nand.c driver apparently has misconfigured ecc.size field: >> >> drivers/mtd/nand/gpmi-nand/gpmi-nand.c: >> ---------->8 ---------- >> 1493 chip->ecc.mode = NAND_ECC_HW; >> 1494 chip->ecc.size = 1; >> 1495 chip->ecc.layout =&gpmi_hw_ecclayout; >> ---------- 8< ---------- [snip] > The gpmi driver does not support the subpage read/write. > I will be happy if the driver works only by setting the > NAND_NO_SUBPAGE_WRITE, without setting the ecc.size. Can we just get rid of NAND_CHIPOPTIONS_MSK and trust that drivers won't set options that aren't appropriate? Possibly replace it with documentation about which options are for chips, which are for drivers, and which (such as NAND_NO_SUBPAGE_WRITE) can be set by either. -Scott