From: Steve Dickson <SteveD@redhat.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/3] autoconf: fix up libevent autoconf test
Date: Thu, 05 Jan 2012 16:43:33 -0500 [thread overview]
Message-ID: <4F061985.2040102@RedHat.com> (raw)
In-Reply-To: <1324669625-2948-2-git-send-email-jlayton@redhat.com>
On 12/23/2011 02:47 PM, Jeff Layton wrote:
> Have it set LIBEVENT to -levent and use that in the Makefiles instead
> of hardcoding it.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
Committed...
steved.
> ---
> aclocal/libevent.m4 | 3 ++-
> utils/idmapd/Makefile.am | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/aclocal/libevent.m4 b/aclocal/libevent.m4
> index 3c962b3..b5ac00f 100644
> --- a/aclocal/libevent.m4
> +++ b/aclocal/libevent.m4
> @@ -2,8 +2,9 @@ dnl Checks for libevent
> AC_DEFUN([AC_LIBEVENT], [
>
> dnl Check for libevent, but do not add -levent to LIBS
> - AC_CHECK_LIB([event], [event_dispatch], [libevent=1],
> + AC_CHECK_LIB([event], [event_dispatch], [LIBEVENT=-levent],
> [AC_MSG_ERROR([libevent not found.])])
> + AC_SUBST(LIBEVENT)
>
> AC_CHECK_HEADERS([event.h], ,
> [AC_MSG_ERROR([libevent headers not found.])])
> diff --git a/utils/idmapd/Makefile.am b/utils/idmapd/Makefile.am
> index 4328e41..f8578b0 100644
> --- a/utils/idmapd/Makefile.am
> +++ b/utils/idmapd/Makefile.am
> @@ -16,7 +16,7 @@ idmapd_SOURCES = \
> nfs_idmap.h \
> queue.h
>
> -idmapd_LDADD = -levent -lnfsidmap ../../support/nfs/libnfs.a
> +idmapd_LDADD = $(LIBEVENT) -lnfsidmap ../../support/nfs/libnfs.a
>
> MAINTAINERCLEANFILES = Makefile.in
>
next prev parent reply other threads:[~2012-01-05 21:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-23 19:47 [PATCH 0/3] autoconf: clean up linking in nfs-utils Jeff Layton
2011-12-23 19:47 ` [PATCH 1/3] autoconf: fix up libevent autoconf test Jeff Layton
2012-01-05 21:43 ` Steve Dickson [this message]
2011-12-23 19:47 ` [PATCH 2/3] autoconf: don't let libnfsidmap test add -lnfsidmap to $LIBS Jeff Layton
2012-01-05 21:44 ` Steve Dickson
2011-12-23 19:47 ` [PATCH 3/3] autoconf: only link binaries that need it to libtirpc Jeff Layton
2011-12-24 14:54 ` [PATCH 0/3] autoconf: clean up linking in nfs-utils Jim Rees
2011-12-24 16:53 ` Jim Rees
2012-01-05 18:37 ` Jeff Layton
2012-01-05 18:57 ` Jim Rees
2012-01-05 19:12 ` Jeff Layton
2012-01-05 20:42 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F061985.2040102@RedHat.com \
--to=steved@redhat.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.