From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Christian_K=F6nig?= <deathsimple@vodafone.de>
Subject: Re: [PATCH 1/3] drm/radeon: GPU virtual memory support v22
Date: Fri, 06 Jan 2012 13:53:11 +0100
Message-ID: <4F06EEB7.2070901@vodafone.de>
References: <1325819467-2216-1-git-send-email-alexdeucher@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from outgoing.email.vodafone.de (outgoing.email.vodafone.de
	[139.7.28.128])
	by gabe.freedesktop.org (Postfix) with ESMTP id D5B3B9E79A
	for <dri-devel@lists.freedesktop.org>;
	Fri,  6 Jan 2012 05:02:24 -0800 (PST)
In-Reply-To: <1325819467-2216-1-git-send-email-alexdeucher@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: alexdeucher@gmail.com
Cc: Alex Deucher <alexander.deucher@amd.com>, Jerome Glisse <jglisse@redhat.com>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On -10.01.-28163 20:59, alexdeucher@gmail.com wrote:
[SNIP]
>   #define RADEON_CHUNK_ID_RELOCS	0x01
>   #define RADEON_CHUNK_ID_IB	0x02
>   #define RADEON_CHUNK_ID_FLAGS	0x03
>
>   /* The first dword of RADEON_CHUNK_ID_FLAGS is a uint32 of these flags: */
>   #define RADEON_CS_KEEP_TILING_FLAGS 0x01
> +#define RADEON_CS_USE_VM            0x02
> +/* The second dword of RADEON_CHUNK_ID_FLAGS is a uint32 that sets the ring type */
> +#define RADEON_CS_RING_GFX          0
> +#define RADEON_CS_RING_COMPUTE      1
> +/* The third dword of RADEON_CHUNK_ID_FLAGS is a sint32 that sets the priority */
> +/* 0 = normal, + = higher priority, - = lower priority */
> +struct drm_radeon_cs_ring_priority {
> +	int32_t			priority;
> +};
Sorry, missed that one before, the "struct drm_radeon_cs_ring_priority" 
is pretty much pointless.

My comment was going more into that direction:
struct drm_radeon_cs_flags {
     uint32_t      flags;
     uint32_t      ring_type;
     int32_t        priority;
};

Anyway, the patch is finally committed, but I think we should fix 
(remove?) that before it goes further upstream.

Christian.