From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49324) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjWgV-0004uF-MP for qemu-devel@nongnu.org; Sat, 07 Jan 2012 08:51:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RjWgU-0000MQ-MF for qemu-devel@nongnu.org; Sat, 07 Jan 2012 08:51:47 -0500 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:43732) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjWgU-0000MM-GN for qemu-devel@nongnu.org; Sat, 07 Jan 2012 08:51:46 -0500 Message-ID: <4F070B34.8030602@weilnetz.de> Date: Fri, 06 Jan 2012 15:54:44 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1325858346-1071-1-git-send-email-kraxel@redhat.com> <1325858346-1071-7-git-send-email-kraxel@redhat.com> In-Reply-To: <1325858346-1071-7-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 06/12] xhci: Initial xHCI implementation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Hector Martin , qemu-devel@nongnu.org Am 06.01.2012 14:59, schrieb Gerd Hoffmann: > From: Hector Martin > > Based on the implementation from Hector Martin > > Hectors's implementation completely sidestepped the qemu usb system and > used libusb directly for usb device pass through. So I've ripped out > the libusb bits (or left them in disabled, as reference for further > coding) and hooked up the qemu subsystem instead. That work is not > complete yet though, partly due to limitations of the qemu usb > subsystem. Nevertheless I think it is better to continue development > in-tree, especially as the qemu usb bits need a bunch of improvements > too for decent usb 3.0 support. > > Current state: > - usb-storage emulation should work ok. > - Devices which need constant polling (HID emulation like usb-tablet) > are known to not work. > - ISO xfers are not implemented yet. > - superspeed ports are not implemented yet. > - usb pass-through is completely untested so far. > > Signed-off-by: Gerd Hoffmann > --- > Makefile.objs | 1 + > default-configs/pci.mak | 1 + > hw/pci_ids.h | 3 + > hw/usb-xhci.c | 2662 +++++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 2667 insertions(+), 0 deletions(-) > create mode 100644 hw/usb-xhci.c Hi, please use scripts/checkpatch.pl to test this patch. It contains several indented statements (if ... else) without braces. For code which is also used in a non QEMU context, tools like AStyle can fix the formatting for QEMU. Cheers, Stefan Weil