All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	"M. Mohan Kumar" <mohan@in.ibm.com>,
	qemu-devel@nongnu.org, patches@linaro.org,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-9p-proxy: Fix typo causing compile failure on 32 bit hosts
Date: Fri, 06 Jan 2012 13:11:05 -0600	[thread overview]
Message-ID: <4F074749.1000009@codemonkey.ws> (raw)
In-Reply-To: <1325875641-27938-1-git-send-email-peter.maydell@linaro.org>

On 01/06/2012 12:47 PM, Peter Maydell wrote:
> Fix a compile failure on 32 bit hosts (integer constant is too large
> for 'unsigned long' type) by correcting a typo where the mask used
> for filling in the second f_fsid word had too many 'F's in it.
> Also drop the 'L' suffix that allowed this typo to go undetected on
> 64 bit hosts.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
> This was introduced in commit b178adc3e.
>
>   hw/9pfs/virtio-9p-proxy.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/9pfs/virtio-9p-proxy.c b/hw/9pfs/virtio-9p-proxy.c
> index 44f5fc4..d5ad208 100644
> --- a/hw/9pfs/virtio-9p-proxy.c
> +++ b/hw/9pfs/virtio-9p-proxy.c
> @@ -112,8 +112,8 @@ static void prstatfs_to_statfs(struct statfs *stfs, ProxyStatFS *prstfs)
>       stfs->f_bavail = prstfs->f_bavail;
>       stfs->f_files = prstfs->f_files;
>       stfs->f_ffree = prstfs->f_ffree;
> -    stfs->f_fsid.__val[0] = prstfs->f_fsid[0]&  0xFFFFFFFFUL;
> -    stfs->f_fsid.__val[1] = prstfs->f_fsid[1]>>  32&  0xFFFFFFFFFUL;
> +    stfs->f_fsid.__val[0] = prstfs->f_fsid[0]&  0xFFFFFFFFU;
> +    stfs->f_fsid.__val[1] = prstfs->f_fsid[1]>>  32&  0xFFFFFFFFU;
>       stfs->f_namelen = prstfs->f_namelen;
>       stfs->f_frsize = prstfs->f_frsize;
>   }

      reply	other threads:[~2012-01-06 19:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-06 18:47 [Qemu-devel] [PATCH] virtio-9p-proxy: Fix typo causing compile failure on 32 bit hosts Peter Maydell
2012-01-06 19:11 ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F074749.1000009@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=aliguori@us.ibm.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=mohan@in.ibm.com \
    --cc=patches@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.