All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Oliver Endriss <o.endriss@gmx.de>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] drxk: Fix regression introduced by commit '[media] Remove Annex A/C selection via roll-off factor'
Date: Fri, 06 Jan 2012 17:11:56 -0200	[thread overview]
Message-ID: <4F07477C.50900@redhat.com> (raw)
In-Reply-To: <201201041945.58852@orion.escape-edv.de>

On 04-01-2012 16:45, Oliver Endriss wrote:
> Fix regression introduced by commit '[media] Remove Annex A/C selection via roll-off factor'
> As a result of this commit, DVB-T tuning did not work anymore.
> 
> Signed-off-by: Oliver Endriss <o.endriss@gmx.de>
> 
> diff --git a/drivers/media/dvb/frontends/drxk_hard.c b/drivers/media/dvb/frontends/drxk_hard.c
> index 36e1c82..13f22a1 100644
> --- a/drivers/media/dvb/frontends/drxk_hard.c
> +++ b/drivers/media/dvb/frontends/drxk_hard.c
> @@ -6235,6 +6235,8 @@ static int drxk_set_parameters(struct dvb_frontend *fe)
>  	case SYS_DVBC_ANNEX_C:
>  		state->m_itut_annex_c = true;
>  		break;
> +	case SYS_DVBT:
> +		break;
>  	default:
>  		return -EINVAL;
>  	}
> 
Hi Oliver,

Thanks for the patch! 

It become obsoleted by the patch that converted the driver
to create just one frontend:
	http://git.linuxtv.org/media_tree.git/commitdiff/fa4b2a171d42ffc512b3a86922ad68e1355eb17a

While I don't have DVB-T signal here, the logs were showing that the driver is
switching properly between DVB-T and DVB-C.

Yet, I'd appreciate if you could test it with a real signal,
for us to be 100% sure that everything is working as expected.

Thanks!
Mauro

  reply	other threads:[~2012-01-06 19:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-04 18:45 [PATCH] drxk: Fix regression introduced by commit '[media] Remove Annex A/C selection via roll-off factor' Oliver Endriss
2012-01-06 19:11 ` Mauro Carvalho Chehab [this message]
2012-01-07  0:45   ` Oliver Endriss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F07477C.50900@redhat.com \
    --to=mchehab@redhat.com \
    --cc=linux-media@vger.kernel.org \
    --cc=o.endriss@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.