Re: [Autotest PATCH v2 0/4] Network performance regression

[Lucas Meneghel Rodrigues <lmr@redhat.com>]

On 01/05/2012 01:05 AM, Amos Kong wrote:
> This patchset adds a new network perf testcase for Windows,
> refactors old netperf test, and support numa resource control.
> Process the raw results to a 'standard format' at the end of test,
> then we can analyze them with general module, compute average
> and compare with old results.
> User can configure test time/repeat times for getting stable results.
>
> Welcome to give feedback, thanks in advance!

I've made a first review of the series, with comments on your pull request:

https://github.com/autotest/autotest/pull/126

Let me know what you think about my findings.

Cheers,

Lucas

> Changes from v1:
> - refactor analysis module
> - add new features in analysis code
> - shape those two tests
> - fix some script bugs
> - add autoio script for ntttcp test
>
> ---
>
> Amos Kong (4):
>        virt-test: add NTttcp subtests
>        virt-test: Refactor netperf test and add analysis module
>        netperf: pin guest vcpus/memory/vhost thread to numa node
>        virt: Introduce regression testing infrastructure
>
>
>   client/tests/kvm/control        |    7 +
>   client/tests/kvm/perf.conf      |   23 +++
>   client/virt/scripts/ntttcp.au3  |   41 +++++
>   client/virt/subtests.cfg.sample |   59 ++++++-
>   client/virt/tests/analyzer.py   |  172 ++++++++++++++++++++++
>   client/virt/tests/netperf.py    |  312 ++++++++++++++++++++++++++++-----------
>   client/virt/tests/ntttcp.py     |  183 +++++++++++++++++++++++
>   client/virt/tests/regression.py |   34 ++++
>   8 files changed, 733 insertions(+), 98 deletions(-)
>   create mode 100644 client/tests/kvm/perf.conf
>   create mode 100755 client/virt/scripts/ntttcp.au3
>   create mode 100644 client/virt/tests/analyzer.py
>   create mode 100644 client/virt/tests/ntttcp.py
>   create mode 100644 client/virt/tests/regression.py
>