From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Fri, 06 Jan 2012 21:12:27 +0000 Subject: Re: [PATCH 08/50] KVM: PPC: Add support for explicit HIOR setting Message-Id: <4F0763BB.5040107@freescale.com> List-Id: References: <1325639448-9494-1-git-send-email-agraf@suse.de> <1325639448-9494-9-git-send-email-agraf@suse.de> <4F04B2AD.9060404@freescale.com> <8CF5DEF6-1200-41A4-B6C5-8C7AE68B2615@suse.de> <4F05DADF.4010403@freescale.com> <571EB8ED-D99F-4F11-A9A1-CE569D2B7A4C@suse.de> In-Reply-To: <571EB8ED-D99F-4F11-A9A1-CE569D2B7A4C@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf Cc: kvm-ppc@vger.kernel.org, kvm list , Avi Kivity , Marcelo Tosatti On 01/05/2012 08:35 PM, Alexander Graf wrote: > Also we're already using KVM_REG for MMIO register identifiers. But I guess we can just reuse the namespace as long as we're careful to not overlap them later. > > #define KVM_REG_MASK 0x001f > #define KVM_REG_EXT_MASK 0xffe0 > #define KVM_REG_GPR 0x0000 > #define KVM_REG_FPR 0x0020 > #define KVM_REG_QPR 0x0040 > #define KVM_REG_FQPR 0x0060 It looks like these are only used internally, despite being in the public header -- so renaming these is an option as well if it'd be confusing otherwise. -Scott From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [PATCH 08/50] KVM: PPC: Add support for explicit HIOR setting Date: Fri, 6 Jan 2012 15:12:27 -0600 Message-ID: <4F0763BB.5040107@freescale.com> References: <1325639448-9494-1-git-send-email-agraf@suse.de> <1325639448-9494-9-git-send-email-agraf@suse.de> <4F04B2AD.9060404@freescale.com> <8CF5DEF6-1200-41A4-B6C5-8C7AE68B2615@suse.de> <4F05DADF.4010403@freescale.com> <571EB8ED-D99F-4F11-A9A1-CE569D2B7A4C@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: , kvm list , Avi Kivity , Marcelo Tosatti To: Alexander Graf Return-path: In-Reply-To: <571EB8ED-D99F-4F11-A9A1-CE569D2B7A4C@suse.de> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 01/05/2012 08:35 PM, Alexander Graf wrote: > Also we're already using KVM_REG for MMIO register identifiers. But I guess we can just reuse the namespace as long as we're careful to not overlap them later. > > #define KVM_REG_MASK 0x001f > #define KVM_REG_EXT_MASK 0xffe0 > #define KVM_REG_GPR 0x0000 > #define KVM_REG_FPR 0x0020 > #define KVM_REG_QPR 0x0040 > #define KVM_REG_FQPR 0x0060 It looks like these are only used internally, despite being in the public header -- so renaming these is an option as well if it'd be confusing otherwise. -Scott