From: Luca Olivetti <luca@ventoso.org>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
Patrick Boettcher <pboettcher@kernellabs.com>,
Antti Palosaari <crope@iki.fi>,
Johannes Stezenbach <js@sig21.net>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 2/2] [media] af9005, af9015: use symbolic names for USB id table indices
Date: Sat, 07 Jan 2012 14:57:20 +0100 [thread overview]
Message-ID: <4F084F40.3070703@ventoso.org> (raw)
In-Reply-To: <20120107081127.GC10247@elie.hsd1.il.comcast.net>
Al 07/01/12 09:11, En/na Jonathan Nieder ha escrit:
> The af9005_properties and af9015_properties tables make use of USB ids
> from the USB id tables with hardcoded indices, as in
> "&af9015_usb_table[30]". Adding new entries before the end breaks
> such references, so everyone has had to carefully tiptoe to only add
> entries at the end of the list.
>
> In the spirit of "dw2102: use symbolic names for dw2102_table
> indices", use C99-style initializers with symbolic names for each
> index to avoid this. In the new regime, properties tables referring
> to the USB ids have names like "&af9015_usb_table[CINERGY_T_STICK_RC]"
> that do not change meaning when items in the USB id table are
> reordered.
>
> Encouraged-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Seems good to me, didn't know you could do that in C.
Acked-by: Luca Olivetti <luca@ventoso.org>
Bye
--
Luca
next prev parent reply other threads:[~2012-01-07 16:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111222215356.GA4499@rotes76.wohnheim.uni-kl.de>
2011-12-22 23:44 ` Add support for new Terratec DVB USB IDs Jonathan Nieder
2011-12-23 17:20 ` Patrick Boettcher
2011-12-23 23:00 ` [RFC/PATCH] [media] dw2102: use symbolic names for dw2102_table indices Jonathan Nieder
2012-01-06 13:20 ` Mauro Carvalho Chehab
2012-01-07 8:01 ` [PATCH 0/2] " Jonathan Nieder
2012-01-07 8:05 ` [PATCH 1/2] [media] a800: use symbolic names for a800_table indices Jonathan Nieder
2012-01-07 8:11 ` [PATCH 2/2] [media] af9005, af9015: use symbolic names for USB id table indices Jonathan Nieder
2012-01-07 13:57 ` Luca Olivetti [this message]
2012-01-09 17:49 ` Antti Palosaari
2012-01-06 13:12 ` Add support for new Terratec DVB USB IDs Mauro Carvalho Chehab
2012-03-10 16:04 ` [RFC/PATCH] New Terratec DVB USB IDs, symbolic names in az6027_usb_table Eduard Bloch
2012-03-10 16:40 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F084F40.3070703@ventoso.org \
--to=luca@ventoso.org \
--cc=crope@iki.fi \
--cc=jrnieder@gmail.com \
--cc=js@sig21.net \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=pboettcher@kernellabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.