Re: [PATCH v3 05/10] cdma-netreg: Add provider name and SID support

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1288 bytes --]

Hi Philippe,

> @@ -120,6 +134,30 @@ static void serving_system_callback(const struct ofono_error *error,
>  	}
>  
>  	DBG("Serving system Identifier: %s", sid);
> +
> +	if (cdma_netreg->sid != NULL && !strcmp(cdma_netreg->sid, sid))
> +		return;
> +
> +	g_free(cdma_netreg->provider_name);
> +	g_free(cdma_netreg->sid);
> +	cdma_netreg->provider_name = NULL;
> +	cdma_netreg->sid = g_strdup(sid);
> +
> +	ofono_dbus_signal_property_changed(conn, path,
> +				OFONO_CDMA_NETWORK_REGISTRATION_INTERFACE,
> +				"SystemIdentifier", DBUS_TYPE_STRING,
> +				&cdma_netreg->sid);
> +
> +	if (__ofono_cdma_provision_get_name(sid,
> +				&cdma_netreg->provider_name) == FALSE) {
> +		ofono_warn("Provider name not found");
> +		return;
> +	}
> +
> +	ofono_dbus_signal_property_changed(conn, path,
> +				OFONO_CDMA_NETWORK_REGISTRATION_INTERFACE,
> +				"Name", DBUS_TYPE_STRING,
> +				&cdma_netreg->provider_name);

So in theory the Name might not have changed since there can be multiple
SIDs associated with a name.  Something that should probably be fixed in
a follow-on patch.

>  }
>  
>  static void set_registration_status(struct ofono_cdma_netreg *cdma_netreg,

the first 5 patches in this series have been applied, thanks.

Regards,
-Denis