From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rji0n-0006VV-3c for qemu-devel@nongnu.org; Sat, 07 Jan 2012 20:57:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rji0l-00014T-7W for qemu-devel@nongnu.org; Sat, 07 Jan 2012 20:57:28 -0500 Received: from cantor2.suse.de ([195.135.220.15]:59293 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rji0l-00014M-1d for qemu-devel@nongnu.org; Sat, 07 Jan 2012 20:57:27 -0500 Message-ID: <4F08F7A7.1050408@suse.de> Date: Sun, 08 Jan 2012 02:55:51 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1325551939-24749-1-git-send-email-aliguori@us.ibm.com> <1325551939-24749-27-git-send-email-aliguori@us.ibm.com> <20120108014606.GF20942@hall.aurel32.net> In-Reply-To: <20120108014606.GF20942@hall.aurel32.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 26/30] grackle: remove broken pci device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: Paolo Bonzini , Anthony Liguori , qemu-devel@nongnu.org, Alexander Graf , Markus Armbruster Am 08.01.2012 02:46, schrieb Aurelien Jarno: > On Mon, Jan 02, 2012 at 06:52:15PM -0600, Anthony Liguori wrote: >> I have no idea what's going on here, but this is broken and cannot pos= sibly >> work because: >> >> 1) It's qdev name conflicts with a device that sits on SysBus >> >> 2) The PCI constructor expects a SysBus device... but's it's a PCIDev= ice >> >> If you do qdev_create("grackle"), the code expects to get the SysBus v= ersion >> so drop the mystery PCI version. >> >> Signed-off-by: Anthony Liguori >> --- >> hw/grackle_pci.c | 17 ----------------- >> 1 files changed, 0 insertions(+), 17 deletions(-) >=20 > NACK. Maybe the current code is not correct, but it actually works, and > a PCI host device like this one is definitely needed on the system. >=20 > Trying to apply this patch, qemu-system-ppc fails to start with: >=20 > qemu: hardware error: Unknown device 'grackle' for bus 'PCI' Similar for uni-north and qemu-system-ppc64 or -M mac99 (cf. v1). Now that PReP is somewhat restored on my branch, if Anthony wants, I can send patches to resolve the name conflicts next week. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg