From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjqIM-0001iM-Bs for qemu-devel@nongnu.org; Sun, 08 Jan 2012 05:48:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RjqIL-0002Zi-Hr for qemu-devel@nongnu.org; Sun, 08 Jan 2012 05:48:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:12397) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjqIL-0002ZZ-96 for qemu-devel@nongnu.org; Sun, 08 Jan 2012 05:48:09 -0500 Message-ID: <4F097465.8090103@redhat.com> Date: Sun, 08 Jan 2012 12:48:05 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1325687322-6797-1-git-send-email-avi@redhat.com> <20120104144721.GA5961@redhat.com> <4F05BE55.8030209@weilnetz.de> <20120108091706.GA25444@redhat.com> <4F0969BB.7080208@redhat.com> <20120108101242.GA26189@redhat.com> In-Reply-To: <20120108101242.GA26189@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH master/stable-1.0] pci: fix corrupted pci conf index register by unaligned write List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Stefan Weil , qemu-devel@nongnu.org On 01/08/2012 12:12 PM, Michael S. Tsirkin wrote: > > > > > > > And the check for unaligned writes is, well, unusual :-) > > > > What's unusual? > > > > > > > This seems to be how memory API behaves ... right, Avi? > > > Maybe this should be documented somewhere. > > > > Document what? > > That address passed to callbacks is in fact an offset > from start of the region. > It's documented already (and it's not new - since 8da3ff18097, Dec 2008). -- error compiling committee.c: too many arguments to function