From: Avi Kivity <avi@redhat.com>
To: Nadav Amit <nadav.amit@gmail.com>
Cc: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: fix mov immediate emulation for 64-bit operands
Date: Sun, 08 Jan 2012 16:08:04 +0200 [thread overview]
Message-ID: <4F09A344.8020000@redhat.com> (raw)
In-Reply-To: <4F09A2A0.1060801@redhat.com>
On 01/08/2012 04:05 PM, Avi Kivity wrote:
> >
> > Avi, please acknowledge adding OpImm64.
>
> Yes, OpImm64 is the cleanest IMO. Note it doesn't even cost us a bit.
Note, usually I'd ask for a unit test to accompany the fix, but the
current framework only supports testing instructions that have a memroy
operand. So you're off the hook for now, unless you'd like to extend
the framework.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-01-08 14:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1325967346-12539-1-git-send-email-namit@cs.technion.ac.il>
2012-01-07 20:21 ` [PATCH] KVM: fix mov immediate emulation for 64-bit operands Nadav Amit
2012-01-07 20:25 ` H. Peter Anvin
2012-01-08 0:30 ` Nadav Amit
2012-01-08 1:26 ` Takuya Yoshikawa
2012-01-08 8:47 ` Nadav Amit
2012-01-08 14:05 ` Avi Kivity
2012-01-08 14:08 ` Avi Kivity [this message]
2012-01-08 14:44 ` Nadav Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F09A344.8020000@redhat.com \
--to=avi@redhat.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=nadav.amit@gmail.com \
--cc=takuya.yoshikawa@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.