From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54066) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rjv2p-0002tS-CH for qemu-devel@nongnu.org; Sun, 08 Jan 2012 10:52:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rjv2m-0005Zl-PC for qemu-devel@nongnu.org; Sun, 08 Jan 2012 10:52:27 -0500 Received: from cantor2.suse.de ([195.135.220.15]:54168 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rjv2m-0005Z1-FP for qemu-devel@nongnu.org; Sun, 08 Jan 2012 10:52:24 -0500 Message-ID: <4F09BB5C.3080403@suse.de> Date: Sun, 08 Jan 2012 16:50:52 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1326025876-13241-1-git-send-email-avi@redhat.com> In-Reply-To: <1326025876-13241-1-git-send-email-avi@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Fix vmstate_register_ram() for rom/device regions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: sw@weilnetz.de, qemu-devel@nongnu.org Am 08.01.2012 13:31, schrieb Avi Kivity: > rom/device regions have a ram_addr that is composed of both an I/O hand= ler > (low bits) and RAM region (high bits); but qemu_ram_set_idstr() excepts= just expects :) - if you can still change it on your branch. Andreas > a RAM region. Mask the I/O handler to make it happy. >=20 > Signed-off-by: Avi Kivity > --- > savevm.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) >=20 > diff --git a/savevm.c b/savevm.c > index 88c4bd8..80be1ff 100644 > --- a/savevm.c > +++ b/savevm.c > @@ -2284,7 +2284,7 @@ void do_info_snapshots(Monitor *mon) > =20 > void vmstate_register_ram(MemoryRegion *mr, DeviceState *dev) > { > - qemu_ram_set_idstr(memory_region_get_ram_addr(mr), > + qemu_ram_set_idstr(memory_region_get_ram_addr(mr) & TARGET_PAGE_MA= SK, > memory_region_name(mr), dev); > } > =20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg