All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 4/4] sga: fix copypasta
Date: Sun, 08 Jan 2012 22:47:42 +0100	[thread overview]
Message-ID: <4F0A0EFE.4050808@suse.de> (raw)
In-Reply-To: <CAAu8pHu=WOwZ-1FjDxcX+c7ZaTLWKc=gtbLW5XNmrbUY2DDx-Q@mail.gmail.com>

Add "Fix the name of the init function."?

Am 08.01.2012 22:11, schrieb Blue Swirl:
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>

Reviewed-by: Andreas Färber <afaerber@suse.de>

This seems independent of the other VGA patches and probably should go
in early for Anthony to rebase his second QOM series onto?

Andreas

> ---
>  hw/sga.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/sga.c b/hw/sga.c
> index 7ef750a..ea11937 100644
> --- a/hw/sga.c
> +++ b/hw/sga.c
> @@ -35,7 +35,7 @@ typedef struct ISAGAState {
>      ISADevice dev;
>  } ISASGAState;
> 
> -static int isa_cirrus_vga_initfn(ISADevice *dev)
> +static int sga_initfn(ISADevice *dev)
>  {
>      rom_add_vga(SGABIOS_FILENAME);
>      return 0;
> @@ -45,7 +45,7 @@ static ISADeviceInfo sga_info = {
>      .qdev.name    = "sga",
>      .qdev.desc    = "Serial Graphics Adapter",
>      .qdev.size    = sizeof(ISASGAState),
> -    .init         = isa_cirrus_vga_initfn,
> +    .init         = sga_initfn,
>  };
> 
>  static void sga_register(void)

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

      reply	other threads:[~2012-01-08 21:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-08 21:11 [Qemu-devel] [PATCH 4/4] sga: fix copypasta Blue Swirl
2012-01-08 21:47 ` Andreas Färber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F0A0EFE.4050808@suse.de \
    --to=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.