Re: [PATCH 1/1] archive.bbclass: archive work directoryDistribution

[wenzong fan <wenzong.fan@windriver.com>]

On 01/07/2012 01:39 AM, Phil Blundell wrote:
> On Fri, 2012-01-06 at 16:20 +0800, wenzong.fan@windriver.com wrote:
>    
>> +    if [[ -d ${S}&&  ${S} != ${WORKDIR} ]]; then
>> +        if [[ ${S} =~ "/work-shared/gcc" ]]; then
>> +            # Create temporary sources directory for gcc
>> +            mkdir -p ${PF}/temp
>> +            cp -r ${S} ${PF}
>> +            cp -r ${S}/../temp/* ${PF}/temp
>> +            cp -r ${WORKDIR}/temp/* ${PF}/temp
>> +            tarbase=`pwd`
>>      
> Special-casing gcc like this seems a bit lame.  Is that check really
> needed?
>    

Oh, we might have other packages under this dir, so I'll remove the 
special-casing 'gcc' here.
> Also, will the above code work with all shells?  It looks a bit
> bash-specific to me.
>    
I assume that the bitbake have to run with 'bash', looks like this is 
not right on all distributions.

I'll update this.

Thanks
Wenzong

> p.
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>